Add Python version GenCrc32 code and unit test cases #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cc: Rebecca Cran <[email protected]> Cc: Liming Gao <[email protected]> Cc: Bob Feng <[email protected]> Signed-off-by: Wenzhao Li <[email protected]> Signed-off-by: Yuwei Chen <[email protected]>
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #101 +/- ##
=========================================
+ Coverage 4.27% 4.38% +0.10%
=========================================
Files 182 184 +2
Lines 81605 81734 +129
=========================================
+ Hits 3490 3582 +92
- Misses 78115 78152 +37
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
BobCF
approved these changes
Jun 21, 2023
ghost
approved these changes
Jun 16, 2024
| ## @file | ||
| # Calculate Crc32 value and Verify Crc32 value for input data. | ||
| # | ||
| # Copyright (c) 2007 - 2018, Intel Corporation. All rights reserved.<BR> |
There was a problem hiding this comment.
If this is new code, it should probably be "Copyright (c) 2024...." since it wasn't written in 2007.
| ## @file | ||
| # Calculate Crc32 value and Verify Crc32 value for input data. | ||
| # | ||
| # Copyright (c) 2007 - 2018, Intel Corporation. All rights reserved.<BR> |
There was a problem hiding this comment.
Same command about the copyright line as above.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cc: Rebecca Cran [email protected]
Cc: Liming Gao [email protected]
Cc: Bob Feng [email protected]
Signed-off-by: Wenzhao Li [email protected]
Signed-off-by: Yuwei Chen [email protected]