Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AmdMinBoardPkg/PeiBoardInitPreMemLib: AmdMemoryInfoRange fix #173

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

shkrc
Copy link

@shkrc shkrc commented Jul 26, 2024

EndofAmdMemoryInfoHobPpiGuidCallBack() should only consume information from AmdMemoryInfoRange structure. Hence, the structure should not be modified

Cc: Abdul Lateef Attar [email protected]
Cc: Abner Chang [email protected]
Cc: Paul Grimes [email protected]

EndofAmdMemoryInfoHobPpiGuidCallBack() should only consume
information from AmdMemoryInfoRange structure. Hence, the structure
should not be modified

Cc: Abdul Lateef Attar <[email protected]>
Cc: Abner Chang <[email protected]>
Cc: Paul Grimes <[email protected]>
Signed-off-by: Shankar C <[email protected]>
@abdattar
Copy link
Contributor

Please address the review comments.

@@ -89,7 +89,22 @@ EndofAmdMemoryInfoHobPpiGuidCallBack (
FixedPcdGet32 (PcdAmdSmramAreaSize)
));

AmdMemoryInfoRange->Size -= FixedPcdGet32 (PcdAmdSmramAreaSize);
if (AmdMemoryInfoRange->Size) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As ->Size is not a boolean, we should have the predicate expressions. Such as if (AmdMemoryInfoRange->Size > 0).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants