nuget_publishing: Make license entry in config file optional
#424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #424 +/- ##
=======================================
Coverage 76.95% 76.95%
=======================================
Files 46 46
Lines 4608 4608
=======================================
Hits 3546 3546
Misses 1062 1062 |
|
As discussed offline, @Javagedes is going to make some additional changes |
Previously the NuGet config file required a dummy license value to be present if `--CustomLicensePath` was given. This change removes the dummy value being required. Signed-off-by: Michael Kubacki <[email protected]>
Javagedes
force-pushed
the
do_not_require_dummy_nuget_config_license_value
branch
from
213039a
to
36a32e6
Compare
Javagedes
approved these changes
Feb 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the NuGet config file required a dummy license value to
be present if
--CustomLicensePathwas given. This change removesthe dummy value being required.
Co-authored-by: Joey Vagedes [email protected]
Signed-off-by: Michael Kubacki [email protected]