Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

edk2toolext.capsule: add __init__.py #628

Merged
merged 2 commits into from
Aug 17, 2023

Conversation

Javagedes
Copy link
Contributor

@Javagedes Javagedes commented Aug 15, 2023

__init__.py is missing from edk2toolext/capsule, which causes the module to not be found on local edit installs of the project (i.e. pip install -e .). This commit adds in the expected file.

@Javagedes Javagedes added the bug Something isn't working label Aug 15, 2023
@Javagedes Javagedes added this to the v0.24.0 milestone Aug 15, 2023
@Javagedes Javagedes self-assigned this Aug 15, 2023
@codecov
Copy link

codecov bot commented Aug 15, 2023

Codecov Report

Merging #628 (40b662b) into master (2aff6d8) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #628   +/-   ##
=======================================
  Coverage   78.74%   78.75%           
=======================================
  Files          47       48    +1     
  Lines        4785     4786    +1     
=======================================
+ Hits         3768     3769    +1     
  Misses       1017     1017           
Files Changed Coverage Δ
edk2toolext/capsule/capsule_tool.py 61.90% <ø> (ø)
edk2toolext/capsule/__init__.py 100.00% <100.00%> (ø)
edk2toolext/capsule/signing_helper.py 86.36% <100.00%> (ø)

__init__.py is missing from edk2toolext/capsule, which causes the module
to not be found on local edit installs of the project
(i.e. `pip install -e .`). This commit adds in the expected file.
@Javagedes Javagedes merged commit 2b4e3f3 into tianocore:master Aug 17, 2023
22 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants