OvmfPkg: Rerun dispatcher after initializing virtio-rng #6403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tianocore-assign-reviewers
bot
requested review from
ardbiesheuvel,
elmarco,
jyao1,
kraxel and
tperard
|
mailing list thread: https://edk2.groups.io/g/devel/topic/109008158#msg120623 |
| @@ -539,6 +539,8 @@ PlatformBootManagerBeforeConsole ( | |||
| ConnectVirtioPciRng, | |||
| NULL | |||
| ); | |||
|
|
|||
| gDS->Dispatch (); | |||
There was a problem hiding this comment.
Should we include this fix also in ConnectVirtioPciRng() in OvmfPkg/Library/PlatformBootManagerLibBhyve/BdsPlatform.c ?
There was a problem hiding this comment.
Probably a good idea. I'll open a separate PR for that later.
osteffenrh
force-pushed
the
rhel-58631-upstream
branch
from
a7b0689
to
eb76d78
Compare
Since the pixiefail CVE fix the network stack requires a hardware random number generator. This can currently be a modern CPU supporting the RDRAND instruction or a virtio-rng device. The latter is initialized during the BDS phase. To ensure all depending (network) modules are also started, we need to run the dispatcher once more after the device was initialized. Without this, network boot is not available under certain hardware configurations. Analysed-by: Stefano Garzarella <[email protected]> Suggested-by: Gerd Hoffmann <[email protected]> Signed-off-by: Oliver Steffen <[email protected]>
osteffenrh
force-pushed
the
rhel-58631-upstream
branch
from
eb76d78
to
2138646
Compare
osteffenrh
changed the title
kraxel
approved these changes
Nov 11, 2024
|
What about adding |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Since the pixiefail CVE fix the network stack requires a hardware random number generator. This can currently be a modern CPU supporting the RDRAND instruction or a virtio-rng device.
The latter is initialized during the BDS phase.
To ensure all depending (network) modules are also started, we need to run the dispatcher once more.
Without this, network boot is not available under certain hardware configurations.
How This Was Tested
Run Ovmf in Qemu with a core2duo vCPU, a virtio-rng-pci device and a varying number of isa serial ports. Observe if the network stack is loaded (presence of HTTP/PXE boot entries, for example). With 2 serial ports the netboot is not available.
Integration Instructions
N/A