UefiCpuPkg/MtrrLib: Fix unit test read overflow #6419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
impact:security
tianocore-assign-reviewers
bot
requested review from
jiaxinwu,
kraxel,
niruiyu and
rahul1-kumar
rahul1-kumar
approved these changes
Nov 8, 2024
lgao4
approved these changes
Nov 11, 2024
Change conditional check to check the array index before reading the array member to prevent read past end of buffer. Signed-off-by: Michael D Kinney <[email protected]>
lgao4
force-pushed
the
UefiCpuPkg_MtrrLib_UnitTest_ReadOverflow
branch
from
95ede5d
to
15b1e31
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Change conditional check to check the array index before reading the array member to prevent read past end of buffer.
Detected with use of address sanitizer in host based unit tests in draft PR #6408
How This Was Tested
Run host based unit tests with address sanitizer enabled and the issue is resolved with this change
Integration Instructions