Trying out reviewdog #19

tickinginstant · 2023-08-02T15:45:56Z

No description provided.

hound · 2023-08-02T15:46:01Z

app/models/work.rb

@@ -50,7 +50,7 @@ class Work < ApplicationRecord
  belongs_to :work_skin
  validate :work_skin_allowed, on: :save
  def work_skin_allowed
-    unless self.users.include?(self.work_skin.author) || (self.work_skin.public? && self.work_skin.official?)
+    unless self.users.include?(self.work_skin.author)||(self.work_skin.public?&&self.work_skin.official?)


Style/GuardClause: Use a guard clause (return if self.users.include?(self.work_skin.author)||(self.work_skin.public?&&self.work_skin.official?)) instead of wrapping the code inside a conditional expression.
[Correctable] Style/IfUnlessModifier: Favor modifier unless usage when having a single-line body. Another good alternative is the usage of control flow &&/||.
[Correctable] Layout/SpaceAroundOperators: Surrounding space missing for operator ||.
[Correctable] Layout/SpaceAroundOperators: Surrounding space missing for operator &&.

app/models/work.rb

github-actions · 2023-08-02T15:59:05Z

app/views/works/_work_blurb.html.erb

@@ -1,6 +1,6 @@
 <% # expects "work" %>
-<li id="work_<%= work.id %>" class="<% if is_author_of?(work) %>own <% end %><% if work.unrevealed? %>mystery <% end %>work <%= css_classes_for_creation_blurb(work) %>" role="article">
-  <%= render "works/work_module", work: work %>
+<li id="work_<%= work.id %>" class="works <% if is_author_of?(work) %>own <% end %><% if work.unrevealed? %>mystery <% end %>work <%= css_classes_for_creation_blurb(work) %>" role="article">


_{reported by reviewdog 🐶}
Deprecated class works detected matching the pattern works. Avoid the plural form of these classes.

github-actions · 2023-08-02T15:59:06Z

app/views/works/_work_blurb.html.erb

-<li id="work_<%= work.id %>" class="<% if is_author_of?(work) %>own <% end %><% if work.unrevealed? %>mystery <% end %>work <%= css_classes_for_creation_blurb(work) %>" role="article">
-  <%= render "works/work_module", work: work %>
+<li id="work_<%= work.id %>" class="works <% if is_author_of?(work) %>own <% end %><% if work.unrevealed? %>mystery <% end %>work <%= css_classes_for_creation_blurb(work) %>" role="article">
+  <%=render "works/work_module", :work => work%>


_{reported by reviewdog 🐶}
Style/HashSyntax: Use the new Ruby 1.9 hash syntax.

github-actions · 2023-08-02T15:59:06Z

app/views/works/_work_blurb.html.erb

-<li id="work_<%= work.id %>" class="<% if is_author_of?(work) %>own <% end %><% if work.unrevealed? %>mystery <% end %>work <%= css_classes_for_creation_blurb(work) %>" role="article">
-  <%= render "works/work_module", work: work %>
+<li id="work_<%= work.id %>" class="works <% if is_author_of?(work) %>own <% end %><% if work.unrevealed? %>mystery <% end %>work <%= css_classes_for_creation_blurb(work) %>" role="article">
+  <%=render "works/work_module", :work => work%>


_{reported by reviewdog 🐶}
Use 1 space after <%= instead of 0 space.

github-actions · 2023-08-02T15:59:06Z

app/views/works/_work_blurb.html.erb

-<li id="work_<%= work.id %>" class="<% if is_author_of?(work) %>own <% end %><% if work.unrevealed? %>mystery <% end %>work <%= css_classes_for_creation_blurb(work) %>" role="article">
-  <%= render "works/work_module", work: work %>
+<li id="work_<%= work.id %>" class="works <% if is_author_of?(work) %>own <% end %><% if work.unrevealed? %>mystery <% end %>work <%= css_classes_for_creation_blurb(work) %>" role="article">
+  <%=render "works/work_module", :work => work%>


_{reported by reviewdog 🐶}
Use 1 space before %> instead of 0 space.

hound · 2023-08-02T15:59:38Z

app/models/work.rb

@@ -50,7 +50,7 @@ class Work < ApplicationRecord
  belongs_to :work_skin
  validate :work_skin_allowed, on: :save
  def work_skin_allowed
-    unless self.users.include?(self.work_skin.author) || (self.work_skin.public? && self.work_skin.official?)
+    unless self.users.include?(self.work_skin.author)||(self.work_skin.public? && self.work_skin.official?)


Style/GuardClause: Use a guard clause (return if self.users.include?(self.work_skin.author)||(self.work_skin.public? && self.work_skin.official?)) instead of wrapping the code inside a conditional expression.
[Correctable] Style/IfUnlessModifier: Favor modifier unless usage when having a single-line body. Another good alternative is the usage of control flow &&/||.
[Correctable] Layout/SpaceAroundOperators: Surrounding space missing for operator ||.

github-actions · 2023-08-02T16:01:19Z

app/models/work.rb

@@ -50,7 +50,7 @@ class Work < ApplicationRecord
  belongs_to :work_skin
  validate :work_skin_allowed, on: :save
  def work_skin_allowed
-    unless self.users.include?(self.work_skin.author) || (self.work_skin.public? && self.work_skin.official?)
+    unless self.users.include?(self.work_skin.author)||(self.work_skin.public? && self.work_skin.official?)


📝 [rubocop] <Style/GuardClause> _{reported by reviewdog 🐶}
Use a guard clause (return if self.users.include?(self.work_skin.author)||(self.work_skin.public? && self.work_skin.official?)) instead of wrapping the code inside a conditional expression.

github-actions · 2023-08-02T16:01:19Z

app/models/work.rb

+    unless self.users.include?(self.work_skin.author)||(self.work_skin.public? && self.work_skin.official?)
      errors.add(:base, ts("You do not have permission to use that custom work stylesheet."))
    end


📝 [rubocop] <Style/IfUnlessModifier> _{reported by reviewdog 🐶}
Favor modifier unless usage when having a single-line body. Another good alternative is the usage of control flow &&/||.

Suggested change

unless self.users.include?(self.work_skin.author)||(self.work_skin.public? && self.work_skin.official?)

errors.add(:base, ts("You do not have permission to use that custom work stylesheet."))

end

errors.add(:base, ts("You do not have permission to use that custom work stylesheet.")) unless self.users.include?(self.work_skin.author)||(self.work_skin.public? && self.work_skin.official?)

github-actions · 2023-08-02T16:01:19Z

app/models/work.rb

@@ -50,7 +50,7 @@
  belongs_to :work_skin
  validate :work_skin_allowed, on: :save
  def work_skin_allowed
-    unless self.users.include?(self.work_skin.author) || (self.work_skin.public? && self.work_skin.official?)
+    unless self.users.include?(self.work_skin.author)||(self.work_skin.public? && self.work_skin.official?)


📝 [rubocop] <Layout/SpaceAroundOperators> _{reported by reviewdog 🐶}
Surrounding space missing for operator ||.

Suggested change

unless self.users.include?(self.work_skin.author)||(self.work_skin.public? && self.work_skin.official?)

unless self.users.include?(self.work_skin.author) || (self.work_skin.public? && self.work_skin.official?)

tickinginstant added 2 commits August 2, 2023 11:43

Reviewdog?

1585e18

Introduce errors to test.

a466405

hound bot reviewed Aug 2, 2023

View reviewed changes

github-actions bot added the Awaiting Review label Aug 2, 2023

tickinginstant added 2 commits August 2, 2023 11:48

Empty commit to retry.

dfaafd7

Fixup + stop running tests.

dc227fa

github-actions bot reviewed Aug 2, 2023

View reviewed changes

app/models/work.rb Outdated Show resolved Hide resolved

app/models/work.rb Outdated Show resolved Hide resolved

app/models/work.rb Outdated Show resolved Hide resolved

app/models/work.rb Outdated Show resolved Hide resolved

tickinginstant added 3 commits August 2, 2023 11:52

Bump.

cb52354

Use bundler?

c7700f8

Typo.

f3df95b

github-actions bot reviewed Aug 2, 2023

View reviewed changes

hound bot reviewed Aug 2, 2023

View reviewed changes

github-actions bot reviewed Aug 2, 2023

View reviewed changes

Try checks instead of reviews.

9e0bd11

tickinginstant force-pushed the noodling-reviewdog branch from 6553564 to 9e0bd11 Compare August 2, 2023 16:07

tickinginstant added 3 commits August 2, 2023 12:12

Go back to review.

977739f

pull_request_target

8359549

Clean.

ffe0f95

github-actions bot added the Scope: Tests Only label Aug 2, 2023

tickinginstant merged commit c010e0b into main Aug 2, 2023
2 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Trying out reviewdog #19

Trying out reviewdog #19

tickinginstant commented Aug 2, 2023

hound bot Aug 2, 2023

github-actions bot Aug 2, 2023

github-actions bot Aug 2, 2023

github-actions bot Aug 2, 2023

github-actions bot Aug 2, 2023

hound bot Aug 2, 2023

github-actions bot Aug 2, 2023

github-actions bot Aug 2, 2023

github-actions bot Aug 2, 2023

	unless self.users.include?(self.work_skin.author)\|\|(self.work_skin.public? && self.work_skin.official?)
	unless self.users.include?(self.work_skin.author) \|\| (self.work_skin.public? && self.work_skin.official?)

Trying out reviewdog #19

Trying out reviewdog #19

Conversation

tickinginstant commented Aug 2, 2023

hound bot Aug 2, 2023

Choose a reason for hiding this comment

github-actions bot Aug 2, 2023

Choose a reason for hiding this comment

github-actions bot Aug 2, 2023

Choose a reason for hiding this comment

github-actions bot Aug 2, 2023

Choose a reason for hiding this comment

github-actions bot Aug 2, 2023

Choose a reason for hiding this comment

hound bot Aug 2, 2023

Choose a reason for hiding this comment

github-actions bot Aug 2, 2023

Choose a reason for hiding this comment

github-actions bot Aug 2, 2023

Choose a reason for hiding this comment

github-actions bot Aug 2, 2023

Choose a reason for hiding this comment