Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RDB dump #81

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Add RDB dump #81

wants to merge 6 commits into from

Conversation

Morgan279
Copy link
Collaborator

Signed-off-by: Morgan279 [email protected]

Signed-off-by: Morgan279 <[email protected]>
@CLAassistant
Copy link

CLAassistant commented Sep 27, 2022

CLA assistant check
All committers have signed the CLA.

Signed-off-by: Morgan279 <[email protected]>
src/rdb.rs Outdated
.create(true)
.truncate(true)
.write(true)
.open("dump.rdb")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's better to make file name configurable.

@sunxiaoguang
Copy link
Collaborator

sunxiaoguang commented Sep 28, 2022

We should make it possible to disable this command from configuration file. Like rename-command SAVE b840fc02d524045429941cc15f59e41cb7be6c52

But that can be done in a separate PR. Just bear it in mind.

@Morgan279
Copy link
Collaborator Author

Get it.

@Morgan279
Copy link
Collaborator Author

Compatibility tests (redis RDB recovery) under base case in all data types and chaotic data distribution (generated by build-redis-data) have been passed.

Signed-off-by: Morgan279 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants