Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update Github iOS/Android Actions #371

Merged
merged 2 commits into from
Jul 15, 2022
Merged

update Github iOS/Android Actions #371

merged 2 commits into from
Jul 15, 2022

Conversation

m1ga
Copy link
Contributor

@m1ga m1ga commented Jul 15, 2022

  • use SDK 11.0.0
  • use node 14

@m1ga m1ga changed the title update android workflow update Github iOS/Android Actions Jul 15, 2022
@m1ga m1ga mentioned this pull request Jul 15, 2022
Open
@caspahouzer
Copy link
Contributor

I have no idea about the actions but this looks harmless. Is it?

@m1ga
Copy link
Contributor Author

m1ga commented Jul 15, 2022

it just updates 2 versions and you can see that it 🟢 so it will build the module again!
The other PR is ❌ #370 since it fails with Titanium requires Node.js >=14.15.0.

cb1kenobi
cb1kenobi approved these changes Jul 15, 2022
View reviewed changes
Copy link
Contributor

@cb1kenobi cb1kenobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cb1kenobi cb1kenobi merged commit fbdfd43 into tidev:master Jul 15, 2022
@m1ga m1ga deleted the fixAction branch July 15, 2022 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cb1kenobi cb1kenobi cb1kenobi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@m1ga @caspahouzer @cb1kenobi