Support Node.js 18 and 19 #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ns on newer node versions See nodejs/node-gyp#2534 and nodejs/node-gyp#2673 for more context on this issue
As node-pre-gyp is no longer maintained this is the path of least resistance to adding new versions, we include a patch within this project that updates the abi_crosswalk file within node-pre-gyp that is used to map the versions of node to their module/v8 versions. Then in run.js we call patch-package before spawning anything to ensure that our patches are applied correctly. This isn't by any means perfect but it's the quickest way to update the supported versions of node without having to go and make any major refactors to the setup here, or the code in ioslib/the SDK
Closed
31 tasks
cb1kenobi
approved these changes
Jan 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for Node.js 18 and 19 in the simplest way possible (i.e. without any significant build process changes or changes to the SDK or ioslib)
Breaking down each commit:
openssl_fipsto support building for older versions of node on newer versions (17+)abi_crosswalk.jsonwithin node-pre-gyp that is used to map the node version to the module/v8 version. This is required as node-pre-gyp is seemingly no longer maintainedCloses #81