Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR to allow dataframe as validation arg in xgboost #771

Closed
wants to merge 13 commits into from
Closed

PR to allow dataframe as validation arg in xgboost #771

wants to merge 13 commits into from

Commits on Jul 20, 2022

  1. allow user to pass dataframe to validation argument of xgboost. 

    Preserve weights for internal validation set.
    @joeycouse
    joeycouse committed Jul 20, 2022
    Configuration menu
    Copy the full SHA
    11282db View commit details
    Browse the repository at this point in the history

  2. typo

    @joeycouse
    joeycouse committed Jul 20, 2022
    Configuration menu
    Copy the full SHA
    940502b View commit details
    Browse the repository at this point in the history

Commits on Aug 11, 2022

  1. remove name atr of vectors

    @joeycouse
    joeycouse committed Aug 11, 2022
    Configuration menu
    Copy the full SHA
    4338a6c View commit details
    Browse the repository at this point in the history

  2. preserve colnames of y when y is provided as data.frame with numeric … 

    …only
    @joeycouse
    joeycouse committed Aug 11, 2022
    Configuration menu
    Copy the full SHA
    e06547e View commit details
    Browse the repository at this point in the history

  3. remove attempt to add attributes to vectors

    @joeycouse
    joeycouse committed Aug 11, 2022
    Configuration menu
    Copy the full SHA
    b3e249d View commit details
    Browse the repository at this point in the history

  4. * add improved error handling 

    * handles case where validation has additional columns

* add error for when `y` is vector and validation is a dataframe - fit_xy() issue.
    @joeycouse
    joeycouse committed Aug 11, 2022
    Configuration menu
    Copy the full SHA
    5940ef7 View commit details
    Browse the repository at this point in the history

Commits on Aug 22, 2022

  1. Merge branch 'tidymodels:main' into xgb_validation

    @joeycouse
    joeycouse authored Aug 22, 2022
    Configuration menu
    Copy the full SHA
    246e1c0 View commit details
    Browse the repository at this point in the history

  2. support for dataframe as arg for validation

    @joeycouse
    joeycouse committed Aug 22, 2022
    Configuration menu
    Copy the full SHA
    a46404c View commit details
    Browse the repository at this point in the history

  3. update logic to preserve colnames of y

    @joeycouse
    joeycouse committed Aug 22, 2022
    Configuration menu
    Copy the full SHA
    9037d87 View commit details
    Browse the repository at this point in the history

  4. preserve colname of y when y is a factor

    @joeycouse
    joeycouse committed Aug 22, 2022
    Configuration menu
    Copy the full SHA
    10e5133 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'xgb_validation' of https://github.com/joeycouse/parsnip … 

    …into xgb_validation
    @joeycouse
    joeycouse committed Aug 22, 2022
    Configuration menu
    Copy the full SHA
    beda057 View commit details
    Browse the repository at this point in the history

  6. update test to expect named numeric matrix

    @joeycouse
    joeycouse committed Aug 22, 2022
    Configuration menu
    Copy the full SHA
    c175d3e View commit details
    Browse the repository at this point in the history

Commits on Aug 30, 2022

  1. Merge branch 'tidymodels:main' into xgb_validation

    @joeycouse
    joeycouse authored Aug 30, 2022
    Configuration menu
    Copy the full SHA
    66f4219 View commit details
    Browse the repository at this point in the history