Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

We need to add permutations() to the vctrs compatibility files #323

Closed
mikemahoney218 opened this issue Jun 29, 2022 · 3 comments · Fixed by #338
Closed

We need to add permutations() to the vctrs compatibility files #323

mikemahoney218 opened this issue Jun 29, 2022 · 3 comments · Fixed by #338
Assignees
@mikemahoney218

Comments

@mikemahoney218
Copy link
Member

We also do need to add permutations() to the vctrs compatibility files. I think it should just act like other rsets? In terms of binding rows/columns? Worth a little thought, though.

Originally posted by @juliasilge in #321 (comment)
@mikemahoney218
Copy link
Member Author

This is related to #318, I think -- we've got a handful of things which should probably go into the vctrs files soon.

@mikemahoney218 mikemahoney218 self-assigned this Jul 1, 2022
@mikemahoney218
Copy link
Member Author

We think that it's fine to treat permutations like bootstraps (and everything else) and not special-case it at all.

mikemahoney218 added a commit that referenced this issue Jul 5, 2022
@mikemahoney218
Add permutations to rset_subclasses
f1bd335 
This fixes #323.
@mikemahoney218 mikemahoney218 mentioned this issue Jul 5, 2022
Merged
juliasilge pushed a commit that referenced this issue Jul 5, 2022
@mikemahoney218
Add permutations to rset_subclasses (#338)
0f1c6b8 
This fixes #323.
@github-actions
Copy link

This issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.

@github-actions github-actions bot locked and limited conversation to collaborators Jul 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mikemahoney218 mikemahoney218

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add permutations to rset_subclasses tidymodels/rsample
1 participant
@mikemahoney218