-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add group_mc_cv()
#313
Add group_mc_cv()
#313
Conversation
6289e78
to
3072434
Compare
I think that if we like how this is implemented, then we can also quickly add |
...) { | ||
rlang::check_dots_used(call = rlang::caller_env()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking great! 🙌 I have just a couple of comments, one of which is about an existing example.
This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue. |
This PR addresses #207 by adding a new function,
group_mc_cv()
, which can be used to create grouped Monte Carlo cross-validation resamples. Note that the user-facing function doesn't have abalance
argument, because it doesn't make sense to balance anything other than the proportion of data assigned to the assessment fold.This PR also re-organizes code so that grouped functions now live in the same file as their ungrouped variants. I believe we were agreed that would make the most sense going forward, but happy to undo if not.
Created on 2022-06-27 by the reprex package (v2.0.1)