Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Soft-deprecate validation_split() #449

Merged
merged 5 commits into from
Aug 18, 2023
Merged

Conversation

hfrick
Copy link
Member

@hfrick hfrick commented Aug 17, 2023

closes #350

This updates the help page for validation_split() and its variants, adds the deprecation warning, and updates the tests accordingly.

It also updates the vignette that mentions it. We don't use it in extratests, so no changes there. Max was working on updating tidymodels.org and TMwR.

Copy link
Member

@EmilHvitfeldt EmilHvitfeldt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

@hfrick hfrick merged commit 342cfd4 into main Aug 18, 2023
12 checks passed
@hfrick hfrick deleted the soft-deprecate-validation_split branch August 18, 2023 08:37
@github-actions
Copy link

github-actions bot commented Sep 2, 2023

This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.

@github-actions github-actions bot locked and limited conversation to collaborators Sep 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecate validation_split()
2 participants