Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add prompt for params that will not be tuned #549

Merged
merged 19 commits into from
Oct 4, 2022
Merged

add prompt for params that will not be tuned #549

merged 19 commits into from
Oct 4, 2022

Commits on Sep 26, 2022

  1. implement warning for params that will not be tuned, update existing … 

    …snaps
    @simonpcouch
    simonpcouch committed Sep 26, 2022
    Configuration menu
    Copy the full SHA
    4505ab0 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into will-not-tune

    @simonpcouch
    simonpcouch committed Sep 26, 2022
    Configuration menu
    Copy the full SHA
    0c744c6 View commit details
    Browse the repository at this point in the history

  3. add tests for warning re: params that will not tune

    @simonpcouch
    simonpcouch committed Sep 26, 2022
    Configuration menu
    Copy the full SHA
    1fbe543 View commit details
    Browse the repository at this point in the history

  4. add NEWS bullet

    @simonpcouch
    simonpcouch committed Sep 26, 2022
    Configuration menu
    Copy the full SHA
    33cdf60 View commit details
    Browse the repository at this point in the history

Commits on Sep 27, 2022

  1. clarify dependencies

    @simonpcouch
    simonpcouch committed Sep 27, 2022
    Configuration menu
    Copy the full SHA
    3590531 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into will-not-tune

    @simonpcouch
    simonpcouch committed Sep 27, 2022
    Configuration menu
    Copy the full SHA
    8b79be3 View commit details
    Browse the repository at this point in the history

Commits on Sep 28, 2022

  1. Merge branch 'main' into will-not-tune

    @simonpcouch
    simonpcouch authored Sep 28, 2022
    Configuration menu
    Copy the full SHA
    49c9732 View commit details
    Browse the repository at this point in the history

Commits on Sep 30, 2022

  1. Apply suggestions from code review 

    Co-authored-by: Davis Vaughan <[email protected]>
    @topepo @DavisVaughan
    topepo and DavisVaughan authored Sep 30, 2022
    Configuration menu
    Copy the full SHA
    04e7034 View commit details
    Browse the repository at this point in the history

  2. expect_silent -> expect_warning with regexp = NA 

    slightly more granular, but still not as exact as testing with dev `expect_no_warning` with a class
    @simonpcouch
    simonpcouch committed Sep 30, 2022
    Configuration menu
    Copy the full SHA
    14faaa2 View commit details
    Browse the repository at this point in the history

  3. simplify conditions, rephrase prompt 

    only check the model object, as there's not a well-defined analogue for the "engine" in recipes. this also helps simplify the cli machinery.
    @simonpcouch
    simonpcouch committed Sep 30, 2022
    Configuration menu
    Copy the full SHA
    84d08ed View commit details
    Browse the repository at this point in the history

  4. restore current warning, elevate new warning to error

    @simonpcouch
    simonpcouch committed Sep 30, 2022
    Configuration menu
    Copy the full SHA
    1b80824 View commit details
    Browse the repository at this point in the history

  5. extend testing

    @simonpcouch
    simonpcouch committed Sep 30, 2022
    Configuration menu
    Copy the full SHA
    c2be5c8 View commit details
    Browse the repository at this point in the history

  6. update NEWS

    @simonpcouch
    simonpcouch committed Sep 30, 2022
    Configuration menu
    Copy the full SHA
    6dfeee7 View commit details
    Browse the repository at this point in the history

Commits on Oct 3, 2022

  1. Merge branch 'main' into will-not-tune

    @topepo
    topepo authored Oct 3, 2022
    Configuration menu
    Copy the full SHA
    38313f9 View commit details
    Browse the repository at this point in the history

  2. remove outdated remote

    @topepo
    topepo committed Oct 3, 2022
    Configuration menu
    Copy the full SHA
    c741f11 View commit details
    Browse the repository at this point in the history

  3. move new check into sub-function

    @topepo
    topepo committed Oct 3, 2022
    Configuration menu
    Copy the full SHA
    6fd347b View commit details
    Browse the repository at this point in the history

  4. spelling issue

    @topepo
    topepo committed Oct 3, 2022
    Configuration menu
    Copy the full SHA
    178d6a0 View commit details
    Browse the repository at this point in the history

Commits on Oct 4, 2022

  1. check installs for workflow (not just the model object)

    @topepo
    topepo committed Oct 4, 2022
    Configuration menu
    Copy the full SHA
    8338639 View commit details
    Browse the repository at this point in the history

  2. Revert "check installs for workflow (not just the model object)" 

    This reverts commit 8338639.
    @topepo
    topepo committed Oct 4, 2022
    Configuration menu
    Copy the full SHA
    b0cd8e9 View commit details
    Browse the repository at this point in the history