Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix td translations #1545

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

rplsmn
Copy link

@rplsmn rplsmn commented Oct 14, 2024

Fixed as.character and as.double for Teradata

Ajout d'un argument pour le nombre chars
Par défaut 255
Corrige le bug
@rplsmn rplsmn closed this Oct 14, 2024
@simonpcouch
Copy link
Collaborator

Intended to close #1544.

@rplsmn, thanks for the thorough issue description there! It appears you've closed this PR—did you intend to do so? If so, would you be interested in working together to get those checks passing and the PR merged?

@rplsmn
Copy link
Author

rplsmn commented Oct 16, 2024

Hello,

I had opened this PR by mistake while trying to open a PR elsewhere, and since it happened before anyone gave me the permission on my issue I felt like I was being very impolite so I closed it until someone gave me the green light :)
Should I reopen it then ?
I'm very interested in working together on this, yes !

Modified the test for as.double
Modified and added a new test for as.character
@rplsmn rplsmn reopened this Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants