Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop all rows with empty slice() calls #6573

Merged
merged 3 commits into from
Nov 30, 2022
Merged

Drop all rows with empty slice() calls #6573

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
834b3ee
Drop all rows with empty `slice()` calls
DavisVaughan Nov 29, 2022
b829688
NEWS bullet
DavisVaughan Nov 29, 2022
74e76a2
Update revdeps
DavisVaughan Nov 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions NEWS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
# dplyr (development version)

* `slice()` with no inputs now returns 0 rows. This is mostly for theoretical
consistency (#6573).

* `rename_with()` now disallows renaming in the `.cols` tidy-selection (#6561).

* `rename_with()` now checks that the result of `.fn` is the right type and size
Expand Down
3 changes: 0 additions & 3 deletions R/slice.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -314,9 +314,6 @@ slice_rows <- function(.data, ..., .by = NULL, error_call = caller_env()) {
)

dots <- enquos(...)
if (is_empty(dots)) {
return(TRUE)
}

mask <- DataMask$new(.data, by, "slice", error_call = error_call)
on.exit(mask$forget(), add = TRUE)
Expand Down
243 changes: 198 additions & 45 deletions revdep/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,51 +1,204 @@
# Revdeps

## Failed to check (30)
## Failed to check (55)

|package |version |error |warning |note |
|:--------------|:-------|:-----|:-------|:----|
|NA |? | | | |
|NA |? | | | |
|NA |? | | | |
|NA |? | | | |
|NA |? | | | |
|NA |? | | | |
|NA |? | | | |
|NA |? | | | |
|NA |? | | | |
|NA |? | | | |
|NA |? | | | |
|NA |? | | | |
|NA |? | | | |
|NA |? | | | |
|NA |? | | | |
|diproperm |0.2.0 |1 | | |
|NA |? | | | |
|elbird |0.2.3 |1 | | |
|NA |? | | | |
|NA |? | | | |
|NA |? | | | |
|NA |? | | | |
|NA |? | | | |
|loon.ggplot |? | | | |
|loon.shiny |? | | | |
|MarketMatching |? | | | |
|NA |? | | | |
|psychReport |3.0.1 |1 | | |
|TestDimorph |0.4.1 |1 | | |
|vivid |? | | | |
|package |version |error |warning |note |
|:--------------|:-------|:------|:-------|:----|
|NA |? | | | |
|NA |? | | | |
|NA |? | | | |
|NA |? | | | |
|NA |? | | | |
|NA |? | | | |
|NA |? | | | |
|NA |? | | | |
|cinaR |? | | | |
|NA |? | | | |
|NA |? | | | |
|NA |? | | | |
|NA |? | | | |
|NA |? | | | |
|NA |? | | | |
|NA |? | | | |
|NA |? | | | |
|NA |? | | | |
|NA |? | | | |
|NA |? | | | |
|elbird |0.2.5 |1 | | |
|NA |? | | | |
|NA |? | | | |
|NA |? | | | |
|NA |? | | | |
|NA |? | | | |
|genekitr |? | | | |
|ggPMX |? | | | |
|[groupr](failures.md#groupr)|0.1.0 |__+1__ | |-1 |
|immcp |? | | | |
|NA |? | | | |
|NA |? | | | |
|loon.ggplot |? | | | |
|loon.shiny |? | | | |
|NA |? | | | |
|MarketMatching |? | | | |
|NA |? | | | |
|NA |? | | | |
|MSclassifR |0.3.1 |1 | | |
|nlmixr2extra |? | | | |
|nlmixr2plot |? | | | |
|NA |? | | | |
|OlinkAnalyze |? | | | |
|NA |? | | | |
|Platypus |? | | | |
|[rabhit](failures.md#rabhit)|0.2.4 |__+1__ | | |
|NA |? | | | |
|RVA |? | | | |
|NA |? | | | |
|NA |? | | | |
|tidySEM |? | | | |
|NA |? | | | |
|tinyarray |? | | | |
|vivid |? | | | |
|xpose.nlmixr2 |? | | | |

## New problems (9)
## New problems (137)

|package |version |error |warning |note |
|:----------------------------------|:-------|:--------|:-------|:----|
|[brolgar](problems.md#brolgar) |0.1.2 |__+1__ | | |
|[cubble](problems.md#cubble) |0.1.0 | |__+1__ | |
|[gmgm](problems.md#gmgm) |1.1.0 |__+1__ | | |
|[helda](problems.md#helda) |1.1.5 |__+1__ | |1 |
|[hgnc](problems.md#hgnc) |0.1.0 |__+1__ | | |
|[imfr](problems.md#imfr) |0.1.9.1 |1 __+1__ | | |
|[inti](problems.md#inti) |0.5.5 | |__+1__ | |
|[presenter](problems.md#presenter) |0.1.1 | |__+1__ |1 |
|[respR](problems.md#respr) |2.0.2 |__+2__ | | |
|package |version |error |warning |note |
|:---------------------|:-------|:--------|:-------|:----|
|[admiral](problems.md#admiral)|0.8.4 |1 __+1__ | | |
|[APCI](problems.md#apci)|1.0.6 |__+1__ | | |
|[AQuadtree](problems.md#aquadtree)|1.0.2 |__+1__ | |1 |
|[blsR](problems.md#blsr)|0.4.0 | |__+1__ | |
|[bootnet](problems.md#bootnet)|1.5 |__+1__ | | |
|[caffsim](problems.md#caffsim)|0.2.2 |__+1__ | |1 |
|[carpenter](problems.md#carpenter)|0.2.2 |__+2__ |__+1__ |1 |
|[chronicler](problems.md#chronicler)|0.2.0 | |__+1__ | |
|[circumplex](problems.md#circumplex)|0.3.8 |__+2__ |__+1__ |1 |
|[clustrd](problems.md#clustrd)|1.4.0 |__+1__ | | |
|[coefplot](problems.md#coefplot)|1.2.8 |__+1__ | | |
|[cometExactTest](problems.md#cometexacttest)|0.1.5 |__+1__ | | |
|[comperes](problems.md#comperes)|0.2.5 |__+1__ | | |
|[confoundr](problems.md#confoundr)|1.2 |__+2__ |__+1__ | |
|[dbGaPCheckup](problems.md#dbgapcheckup)|1.0.0 |__+1__ |__+1__ | |
|[disk.frame](problems.md#diskframe)|0.7.2 |__+1__ | | |
|[divseg](problems.md#divseg)|0.0.4 |__+2__ | | |
|[dm](problems.md#dm) |1.0.3 |__+2__ | | |
|[dodgr](problems.md#dodgr)|0.2.17 |__+1__ | |2 |
|[dtplyr](problems.md#dtplyr)|1.2.2 |__+1__ | | |
|[dtrackr](problems.md#dtrackr)|0.2.4 | |__+1__ | |
|[eHDPrep](problems.md#ehdprep)|1.2.1 |__+1__ | |1 |
|[epocakir](problems.md#epocakir)|0.9.8 |__+2__ | | |
|[extdplyr](problems.md#extdplyr)|0.1.5 |__+1__ | |1 |
|[exuber](problems.md#exuber)|1.0.0 |__+1__ | | |
|[ffp](problems.md#ffp)|0.2.2 | |__+1__ | |
|[finnts](problems.md#finnts)|0.2.1 |__+1__ | | |
|[forceR](problems.md#forcer)|1.0.15 |__+1__ |__+1__ | |
|[forestmangr](problems.md#forestmangr)|0.9.4 |__+1__ |__+1__ | |
|[fqar](problems.md#fqar)|0.2.1 |__+2__ |__+1__ | |
|[FRK](problems.md#frk)|2.1.0 |__+1__ |1 |1 |
|[funModeling](problems.md#funmodeling)|1.9.4 |__+1__ |__+1__ | |
|[GauPro](problems.md#gaupro)|0.2.6 |__+1__ | |1 |
|[geosimilarity](problems.md#geosimilarity)|2.2 |__+1__ | | |
|[getLattes](problems.md#getlattes)|0.2.0 | |__+1__ |1 |
|[GFE](problems.md#gfe)|0.1.0 |__+1__ | |1 |
|[ggblanket](problems.md#ggblanket)|1.6.1 |__+1__ |__+1__ | |
|[glmdisc](problems.md#glmdisc)|0.6 |__+1__ | |2 |
|[graphicalVAR](problems.md#graphicalvar)|0.3 |__+1__ | | |
|[gratia](problems.md#gratia)|0.7.3 |__+1__ | | |
|[hablar](problems.md#hablar)|0.3.1 |__+1__ |__+1__ | |
|[headliner](problems.md#headliner)|0.0.2 |__+1__ | | |
|[heemod](problems.md#heemod)|0.14.4 | |__+1__ | |
|[helda](problems.md#helda)|1.1.5 |__+1__ | |1 |
|[hlaR](problems.md#hlar)|0.1.5 |__+1__ |__+1__ | |
|[huito](problems.md#huito)|0.2.1 | |__+1__ | |
|[huxtable](problems.md#huxtable)|5.5.1 |__+2__ | |1 |
|[IBCF.MTME](problems.md#ibcfmtme)|1.6-0 |__+1__ | | |
|[interplot](problems.md#interplot)|0.2.3 | |__+1__ |1 |
|[iNZightTools](problems.md#inzighttools)|1.12.3 |__+1__ | | |
|[ipft](problems.md#ipft)|0.7.2 |__+1__ | | |
|[janitor](problems.md#janitor)|2.1.0 |__+1__ |__+1__ |1 |
|[jpgrid](problems.md#jpgrid)|0.2.0 |__+1__ | |1 |
|[jstable](problems.md#jstable)|1.0.7 | |__+1__ | |
|[JumpeR](problems.md#jumper)|0.3.0 |__+1__ | | |
|[kmscv](problems.md#kmscv)|0.1.0 |__+1__ | | |
|[Lahman](problems.md#lahman)|10.0-1 |__+1__ |__+1__ |1 |
|[lans2r](problems.md#lans2r)|1.1.0 |__+1__ | |1 |
|[lillies](problems.md#lillies)|0.2.9 |__+1__ | |1 |
|[mark](problems.md#mark)|0.5.3 | |__+1__ | |
|[MBNMAtime](problems.md#mbnmatime)|0.2.1 |__+1__ | |1 |
|[MetAlyzer](problems.md#metalyzer)|0.1.0 | |__+1__ | |
|[missCompare](problems.md#misscompare)|1.0.3 |__+1__ | | |
|[MRFcov](problems.md#mrfcov)|1.0.38 |__+2__ |__+1__ | |
|[mrgsim.parallel](problems.md#mrgsimparallel)|0.2.1 | |__+1__ | |
|[MSiP](problems.md#msip)|1.3.7 |__+1__ |__+1__ |1 |
|[mudata2](problems.md#mudata2)|1.1.2 |__+2__ |__+1__ |1 |
|[multicolor](problems.md#multicolor)|0.1.5 |__+1__ | |1 |
|[naniar](problems.md#naniar)|0.6.1 | |__+1__ | |
|[ncappc](problems.md#ncappc)|0.3.0 |__+1__ | |2 |
|[NobBS](problems.md#nobbs)|0.1.0 |__+1__ | | |
|[nonmemica](problems.md#nonmemica)|0.9.9 |__+1__ | | |
|[ontologics](problems.md#ontologics)|0.5.2 |__+1__ |__+1__ | |
|[openalexR](problems.md#openalexr)|1.0.0 | |__+1__ | |
|[overviewR](problems.md#overviewr)|0.0.11 |__+1__ |__+1__ | |
|[PAC](problems.md#pac)|1.1.4 |__+1__ |__+1__ | |
|[panelr](problems.md#panelr)|0.7.6 |__+1__ | |1 |
|[PDtoolkit](problems.md#pdtoolkit)|1.0.0 |__+1__ | | |
|[phase1PRMD](problems.md#phase1prmd)|1.0.2 |__+1__ | |1 |
|[PHEindicatormethods](problems.md#pheindicatormethods)|1.4.1 |__+1__ | | |
|[phenofit](problems.md#phenofit)|0.3.7 |__+2__ |__+1__ |1 |
|[PKNCA](problems.md#pknca)|0.10.0 |__+1__ | | |
|[PPforest](problems.md#ppforest)|0.1.3 | |__+1__ |1 |
|[presenter](problems.md#presenter)|0.1.1 | |__+1__ |1 |
|[prevtoinc](problems.md#prevtoinc)|0.12.0 |__+1__ |__+1__ |1 |
|[prozor](problems.md#prozor)|0.3.1 |__+1__ |__+1__ | |
|[psychonetrics](problems.md#psychonetrics)|0.10 |__+1__ | |1 |
|[PVplr](problems.md#pvplr)|0.1.1 |__+1__ | | |
|[questionr](problems.md#questionr)|0.7.7 |__+1__ | |1 |
|[r2dii.analysis](problems.md#r2diianalysis)|0.2.1 |__+1__ | | |
|[randomForestExplainer](problems.md#randomforestexplainer)|0.10.1 |__+2__ | |1 |
|[recipes](problems.md#recipes)|1.0.3 |__+1__ | |1 |
|[RKorAPClient](problems.md#rkorapclient)|0.7.5 | |__+1__ | |
|[RNeXML](problems.md#rnexml)|2.4.8 |__+1__ | | |
|[romic](problems.md#romic)|1.0.0 |__+1__ | | |
|[rsample](problems.md#rsample)|1.1.0 |__+1__ | | |
|[ruler](problems.md#ruler)|0.2.4 | |__+1__ |1 |
|[salesforcer](problems.md#salesforcer)|1.0.1 | |__+1__ | |
|[seecolor](problems.md#seecolor)|0.1.0 |__+1__ |__+1__ |2 |
|[sf](problems.md#sf) |1.0-9 | |__+1__ |1 |
|[sfc](problems.md#sfc)|0.1.0 |__+1__ | |1 |
|[sftime](problems.md#sftime)|0.2-0 | |__+1__ | |
|[simplevis](problems.md#simplevis)|6.4.0 | |__+1__ | |
|[sjmisc](problems.md#sjmisc)|2.8.9 |__+1__ |__+1__ | |
|[sjPlot](problems.md#sjplot)|2.8.12 | |__+1__ | |
|[skater](problems.md#skater)|0.1.1 |__+2__ |__+1__ | |
|[skimr](problems.md#skimr)|2.1.4 |__+1__ |__+1__ | |
|[skynet](problems.md#skynet)|1.4.3 |__+2__ |__+1__ |1 |
|[slackr](problems.md#slackr)|3.2.0 | |__+1__ |1 |
|[soiltestcorr](problems.md#soiltestcorr)|2.1.2 | |__+1__ | |
|[staRdom](problems.md#stardom)|1.1.25 | |__+1__ | |
|[stars](problems.md#stars)|0.6-0 |__+1__ |__+1__ |1 |
|[starschemar](problems.md#starschemar)|1.2.0 |__+2__ |__+1__ |1 |
|[statVisual](problems.md#statvisual)|1.2.1 |__+1__ |__+1__ |1 |
|[styler](problems.md#styler)|1.8.1 | |__+1__ | |
|[suddengains](problems.md#suddengains)|0.4.4 |__+1__ |__+1__ | |
|[SwimmeR](problems.md#swimmer)|0.13.0 |__+2__ |__+1__ | |
|[table.express](problems.md#tableexpress)|0.4.1 |__+1__ | | |
|[tabshiftr](problems.md#tabshiftr)|0.4.0 |__+1__ | | |
|[tabularaster](problems.md#tabularaster)|0.7.1 | |__+1__ | |
|[textrecipes](problems.md#textrecipes)|1.0.1 |__+1__ | |1 |
|[tidyboot](problems.md#tidyboot)|0.1.1 |__+1__ | |1 |
|[tidyCDISC](problems.md#tidycdisc)|0.1.0 |__+1__ | | |
|[tidygraph](problems.md#tidygraph)|1.2.2 |__+1__ |__+1__ | |
|[tidyplus](problems.md#tidyplus)|0.0.1 |__+1__ | | |
|[tidyquery](problems.md#tidyquery)|0.2.3 |__+1__ | | |
|[tidyterra](problems.md#tidyterra)|0.3.1 |__+1__ | | |
|[tidytransit](problems.md#tidytransit)|1.4 |__+1__ | |2 |
|[tidytree](problems.md#tidytree)|0.4.1 |__+1__ | | |
|[TKCat](problems.md#tkcat)|1.0.6 | |__+1__ | |
|[track2KBA](problems.md#track2kba)|1.0.4 |__+2__ | | |
|[tsibble](problems.md#tsibble)|1.1.3 | |__+1__ | |
|[unpivotr](problems.md#unpivotr)|0.6.2 |__+2__ |__+1__ | |
|[useful](problems.md#useful)|1.2.6 |__+2__ | | |
|[wrangle](problems.md#wrangle)|0.5.7 |__+1__ | | |
|[xpose](problems.md#xpose)|0.4.14 |__+1__ | | |
|[xray](problems.md#xray)|0.2 |__+1__ | | |

Loading