Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create quosures in tally_n() #7046

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Create quosures in tally_n() #7046

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7d19060
Create quosures in `tally_n()`
krlmlr Jun 30, 2024
cb870a9
Merge branch 'main' into b-tally-quosure
krlmlr Oct 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions R/count-tally.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,9 +213,9 @@ tally_n <- function(x, wt) {
}

if (quo_is_null(wt)) {
expr(n())
new_quosure(expr(n()), asNamespace("dplyr"))
} else {
expr(sum(!!wt, na.rm = TRUE))
new_quosure(expr(sum(!!wt, na.rm = TRUE)), quo_get_env(wt))
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This probably should be:

Suggested change
new_quosure(expr(sum(!!wt, na.rm = TRUE)), quo_get_env(wt))
new_quosure(expr(sum(!!wt, na.rm = TRUE)), baseenv())

}
}

Expand Down
Loading