Implement tidyeval for benchplot()(#2816)

Closes #2699
tidyverse · Aug 10, 2018 · 5f868c5 · 5f868c5
1 parent c9eb593
commit 5f868c5
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 2 deletions.
diff --git a/NEWS.md b/NEWS.md
@@ -1,5 +1,7 @@
 # ggplot2 3.0.0.9000
 
+*   `benchplot()` now uses tidy evaluation (@dpseidel, #2699).
+
 *   `fortify()` now displays a more informative error message for
     `grouped_df()` objects when dplyr is not installed (@jimhester, #2822).
 

diff --git a/R/bench.r b/R/bench.r
@@ -7,9 +7,14 @@
 #' @examples
 #' benchplot(ggplot(mtcars, aes(mpg, wt)) + geom_point())
 #' benchplot(ggplot(mtcars, aes(mpg, wt)) + geom_point() + facet_grid(. ~ cyl))
-benchplot <- function(x) {
+#'
+#' # With tidy eval:
+#' p <- expr(ggplot(mtcars, aes(mpg, wt)) + geom_point())
+#' benchplot(!!p)
 
-  construct <- system.time(force(x))
+benchplot <- function(x) {
+  x <- enquo(x)
+  construct <- system.time(x <- rlang::eval_tidy(x))
   stopifnot(inherits(x, "ggplot"))
 
   build <- system.time(data <- ggplot_build(x))

diff --git a/man/benchplot.Rd b/man/benchplot.Rd