Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

scale_details arguments in Coords should be renamed panel_scales or scale #1311

Closed
wch opened this issue Aug 31, 2015 · 0 comments
Closed

scale_details arguments in Coords should be renamed panel_scales or scale #1311

wch opened this issue Aug 31, 2015 · 0 comments
Assignees
@thomasp85
Labels
feature a feature request or enhancement

Comments

@wch
Copy link
Member

wch commented Aug 31, 2015

In the Coord objects, many methods take a scale_details argument. They should be changed to panel_scales or scale, depending on whether the argument is a real scale object.
@hadley hadley added feature a feature request or enhancement ready labels Jul 28, 2016
@hadley hadley mentioned this issue Jan 24, 2017
Merged
hadley added a commit that referenced this issue Jan 24, 2017
@hadley
Rename panel_scales to panel_params
157aa55 
Fixes #1311
@hadley hadley closed this as completed in 232c82f Jan 26, 2017
@lock lock bot locked as resolved and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@thomasp85 thomasp85

Labels
feature a feature request or enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@hadley @wch @thomasp85