Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix back-transformation of ranges in coords, without API cleanup #2832

Merged
merged 11 commits into from
Aug 23, 2018

Conversation

clauswilke
Copy link
Member

This PR fixes #2149 and #2812. It is essentially the same as PR #2821, except here the range() function is not renamed. This makes this a non-breaking fix that should be good for 3.0.1. I'm keeping PR #2821 open for its API cleanup, which I think is still appropriate but should be done later.

Copy link
Member

@hadley hadley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please pull the spurious documentation changes into a different PR?

@clauswilke
Copy link
Member Author

@hadley Regarding spurious documentation changes, see #2833. I think the simplest way forward will be to merge that PR and then rebase this one.

@clauswilke
Copy link
Member Author

Spurious documentation changes are removed.

@clauswilke clauswilke merged commit 01155ba into tidyverse:master Aug 23, 2018
@clauswilke clauswilke deleted the issue-2149-range-bugfix-only branch August 23, 2018 19:44
schloerke added a commit to schloerke/shiny that referenced this pull request Sep 16, 2018
…ersion of ggplot2

Originally caused by tidyverse/ggplot2#2832

Need to wait for tidyverse/ggplot2#2821 to be merged.

Expecting a bug fix release between 3.0.0 and when this bug will be fixed, so can not compare against pkg versions. :-/
@lock
Copy link

lock bot commented Feb 19, 2019

This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/

@lock lock bot locked and limited conversation to collaborators Feb 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Double coordinate transformations for geoms that draw with other geoms
2 participants