default formula argument to NULL in geom_smooth() #3307

bfgray3 · 2019-05-07T03:43:23Z

clauswilke · 2019-05-07T18:35:08Z

Unfortunately you just missed the cutoff for the 3.2.0 release, so this will probably have to wait a while until 3.2.0 is out the door.

Generally looks good to me, but one issue I see is that I believe things will break if a method argument is provided (e.g., method = "lm") and a formula is not. The setup_params() method should check for a NULL formula and substitute y ~ x, somewhere around here:

ggplot2/R/stat-smooth.r

Lines 102 to 103 in 508e1bc


	params

Also, to actually close #3205, you'd have to insert the default gam formula if formula is NULL in this if statement:

ggplot2/R/stat-smooth.r

Lines 99 to 101 in 508e1bc

    
           if (identical(params$method, "gam")) { 
        
             params$method <- mgcv::gam 
        
           }

hadley · 2019-06-04T16:02:09Z

R/stat-smooth.r

@@ -86,21 +88,25 @@ StatSmooth <- ggproto("StatSmooth", Stat,

      if (max_group < 1000) {
        params$method <- "loess"
+        params$formula <- params$formula %||% (y ~ x)


You're now setting the formula in two places — I don't think you need to set when figuring out which method to use, you can just set it once the method is known.

If the formula isn't set before the message() call just below, then the message could include a NULL instead of the relevant formula, breaking this test for example. Maybe a solution could be to have a logical keep track of whether or not params$method is originally "auto" and then move the message() call down until after the formula has been set once and wrap it in if (using_auto_method), although that doesn't seem great to me.

Oh, I see the problem — now that method and formula are being set independently, you need to break that message up into two pieces. You should only ever inform the user when the parameter was chosen automatically, not when they supplied it.

hadley · 2019-06-05T11:39:29Z

R/stat-smooth.r

@@ -86,21 +88,25 @@ StatSmooth <- ggproto("StatSmooth", Stat,

      if (max_group < 1000) {
        params$method <- "loess"
+        params$formula <- params$formula %||% (y ~ x)


Oh, I see the problem — now that method and formula are being set independently, you need to break that message up into two pieces. You should only ever inform the user when the parameter was chosen automatically, not when they supplied it.

R/stat-smooth.r

hadley · 2019-06-05T11:41:29Z

R/stat-smooth.r

    }

    params
  },

-  compute_group = function(data, scales, method = "auto", formula = y~x,
+  compute_group = function(data, scales, method = "auto", formula = NULL,


This should probably have method = "loess" and formula = y ~ x

hadley · 2019-06-14T14:48:54Z

R/geom-smooth.r

@@ -91,7 +91,7 @@ geom_smooth <- function(mapping = NULL, data = NULL,
    ...
  )
  if (identical(stat, "smooth")) {
-    params$method <- method
+    params$method <- if (!is.null(method) && identical(method, "auto")) NULL else method


This check should be handled lower down so you don't need to repeat it in both geom_smooth() and stat_smooth()

hadley · 2019-06-14T14:49:22Z

R/stat-smooth.r

@@ -78,7 +82,8 @@ stat_smooth <- function(mapping = NULL, data = NULL,
 StatSmooth <- ggproto("StatSmooth", Stat,

  setup_params = function(data, params) {
-    if (identical(params$method, "auto")) {
+    msg <- NULL


I think it would be easier to do msg <- character()

hadley · 2019-06-14T14:49:36Z

R/stat-smooth.r

-      message("`geom_smooth()` using method = '", params$method,
-              "' and formula '", deparse(params$formula), "'")
+
+      msg <- paste0("`geom_smooth()` using method = '", params$method, "'")


Then this becomes msg <- c(msg, paste0("method ='", ...)

hadley · 2019-06-14T14:51:45Z

R/stat-smooth.r

    if (identical(params$method, "gam")) {
      params$method <- mgcv::gam
    }

+    if (!is.null(msg)) {
+      message(msg)


Then here you do:

if (length(msg) > 0) { message("geom_smooth() using ", paste0(msg, collapse = " and ")) }

thomasp85 · 2019-09-27T06:55:05Z

@hadley any reason this hasn't been merged in yet?

hadley · 2019-09-27T13:40:33Z

@thomasp85 Can you fix the style at https://github.com/tidyverse/ggplot2/pull/3307/files#diff- 10973f7c4485dfcd2b91934488f19f2aR101? Then I think you can merge.

…gray3-geom-smooth-formula

commit b049018 Merge: e1846bc ccf0ee5 Author: Thomas Knecht <[email protected]> Date: Mon Oct 7 12:29:23 2019 +0200 Resolve conflict Merge branch 'Add_position_nudgestack' of https://github.com/ThomasKnecht/ggplot2 into Add_position_nudgestack # Conflicts: # R/position-nudgestack.R commit e1846bc Author: Thomas Knecht <[email protected]> Date: Mon Oct 7 11:58:47 2019 +0200 Add package spezifications commit 5de0449 Author: Thomas Knecht <[email protected]> Date: Mon Oct 7 11:53:06 2019 +0200 Add package spezifications commit d9ec752 Author: Thomas Knecht <[email protected]> Date: Tue Oct 1 09:20:41 2019 +0200 Style file commit e0368b0 Author: Thomas Knecht <[email protected]> Date: Tue Oct 1 08:51:55 2019 +0200 Resolve conflict commit 325456a Author: Thomas Knecht <[email protected]> Date: Tue Sep 17 16:09:49 2019 +0200 Add new examples commit 3210061 Author: Thomas Knecht <[email protected]> Date: Tue Sep 17 15:39:56 2019 +0200 Add the zoo-package to Suggestions commit 739ac7c Author: Thomas Knecht <[email protected]> Date: Wed Sep 18 15:55:02 2019 +0200 Add tests for correct nudging and stacking commit 662a5da Author: Thomas Knecht <[email protected]> Date: Tue Sep 17 18:03:12 2019 +0200 Add validated svg for position_nudgestack commit 598b786 Author: Thomas Knecht <[email protected]> Date: Tue Sep 17 18:02:29 2019 +0200 Add test file with a doppelganger-test commit 90d1257 Author: Thomas Knecht <[email protected]> Date: Mon Sep 16 13:47:58 2019 +0200 Add time series example commit 415811c Author: Thomas Knecht <[email protected]> Date: Tue Oct 1 09:44:37 2019 +0200 Add news commit 6e4398c Author: Thomas Knecht <[email protected]> Date: Tue Oct 1 09:20:41 2019 +0200 Style file commit b61211d Author: Thomas Knecht <[email protected]> Date: Tue Oct 1 09:20:41 2019 +0200 Style file commit 369a34b Author: Thomas Knecht <[email protected]> Date: Mon Sep 30 14:06:24 2019 +0200 Use tsbox for converting ts object to tibble commit e4e7ee0 Author: Thomas Knecht <[email protected]> Date: Tue Oct 1 08:51:55 2019 +0200 Resolve conflict commit 4d66dad Author: Thomas Knecht <[email protected]> Date: Wed Sep 18 15:55:02 2019 +0200 Add tests for correct nudging and stacking commit 1b61750 Author: Thomas Knecht <[email protected]> Date: Tue Sep 17 18:02:29 2019 +0200 Add test file with a doppelganger-test commit 65e72fb Author: Thomas Knecht <[email protected]> Date: Tue Sep 17 16:09:49 2019 +0200 Add new examples commit e5d61b5 Author: Thomas Knecht <[email protected]> Date: Tue Sep 17 16:06:00 2019 +0200 Adjust filter criterion in examples commit 8848fd9 Author: Thomas Knecht <[email protected]> Date: Mon Sep 30 14:06:24 2019 +0200 Use tsbox for converting ts object to tibble commit 28640d5 Author: Thomas Knecht <[email protected]> Date: Fri Sep 27 15:58:51 2019 +0200 Bugfix commit 59bc2a0 Author: Thomas Knecht <[email protected]> Date: Mon Sep 16 14:00:28 2019 +0200 Add position-nudgestack.R into man commit 71d567b Author: Thomas Knecht <[email protected]> Date: Mon Sep 16 13:47:58 2019 +0200 Add time series example commit 3a1c71f Author: Thomas Knecht <[email protected]> Date: Wed Sep 18 15:55:02 2019 +0200 Add tests for correct nudging and stacking commit f26bb90 Author: Thomas Knecht <[email protected]> Date: Tue Sep 17 18:03:12 2019 +0200 Add validated svg for position_nudgestack commit 3ba06ab Author: Thomas Knecht <[email protected]> Date: Tue Sep 17 18:02:29 2019 +0200 Add test file with a doppelganger-test commit fbf28dc Author: Thomas Knecht <[email protected]> Date: Tue Sep 17 16:09:49 2019 +0200 Add new examples commit 5270a9d Author: Thomas Knecht <[email protected]> Date: Tue Sep 17 16:09:20 2019 +0200 Delete packages from @examples commit 32d2203 Author: Thomas Knecht <[email protected]> Date: Tue Sep 17 16:06:00 2019 +0200 Adjust filter criterion in examples commit fc6ba5a Author: Thomas Knecht <[email protected]> Date: Tue Sep 17 15:39:56 2019 +0200 Add the zoo-package to Suggestions commit b1bb9d1 Author: Thomas Knecht <[email protected]> Date: Mon Sep 16 14:00:28 2019 +0200 Add position-nudgestack.R into man commit d1c7ad8 Author: Thomas Knecht <[email protected]> Date: Mon Sep 16 13:58:38 2019 +0200 Add new position_nudgestack into NAMESPACE commit 621730d Author: Thomas Knecht <[email protected]> Date: Mon Sep 16 13:56:35 2019 +0200 Add new position to DESCRIPTION commit 0750e55 Author: Thomas Knecht <[email protected]> Date: Mon Sep 16 13:47:58 2019 +0200 Add time series example commit ce942ac Author: Thomas Knecht <[email protected]> Date: Tue Sep 3 09:26:32 2019 +0200 Delete emtpy rows commit 86dfea0 Author: Thomas Knecht <[email protected]> Date: Tue Sep 3 09:09:06 2019 +0200 Add position_nudgestack commit ccf0ee5 Author: Thomas Knecht <[email protected]> Date: Mon Oct 7 11:58:47 2019 +0200 Add package spezifications commit 831d569 Author: Thomas Knecht <[email protected]> Date: Mon Oct 7 11:53:06 2019 +0200 Add package spezifications commit af4abb5 Merge: 0a89016 0ff81cb Author: Thomas Knecht <[email protected]> Date: Wed Oct 2 16:37:11 2019 +0200 Resolve conflict Merge branch 'Add_position_nudgestack' of https://github.com/ThomasKnecht/ggplot2 into Add_position_nudgestack # Conflicts: # R/position-nudgestack.R commit 0a89016 Author: Thomas Knecht <[email protected]> Date: Tue Oct 1 09:44:37 2019 +0200 Add news commit 083454a Author: Thomas Knecht <[email protected]> Date: Tue Oct 1 09:20:41 2019 +0200 Style file commit 9cdcf6a Author: Thomas Knecht <[email protected]> Date: Tue Oct 1 09:20:41 2019 +0200 Style file commit 7d23e89 Author: Thomas Knecht <[email protected]> Date: Tue Oct 1 08:51:55 2019 +0200 Resolve conflict commit 99eab52 Author: Thomas Knecht <[email protected]> Date: Tue Sep 17 16:09:49 2019 +0200 Add new examples commit 5fa6969 Author: Thomas Knecht <[email protected]> Date: Tue Sep 17 15:39:56 2019 +0200 Add the zoo-package to Suggestions commit 8642839 Author: Thomas Knecht <[email protected]> Date: Mon Sep 30 14:06:24 2019 +0200 Use tsbox for converting ts object to tibble commit f891dbc Author: Thomas Knecht <[email protected]> Date: Fri Sep 27 15:58:51 2019 +0200 Bugfix commit a960ca8 Author: Thomas Knecht <[email protected]> Date: Wed Sep 18 15:55:02 2019 +0200 Add tests for correct nudging and stacking commit 5b89b32 Author: Thomas Knecht <[email protected]> Date: Tue Sep 17 18:03:12 2019 +0200 Add validated svg for position_nudgestack commit 37f1bd6 Author: Thomas Knecht <[email protected]> Date: Tue Sep 17 18:02:29 2019 +0200 Add test file with a doppelganger-test commit e392ac8 Author: Thomas Knecht <[email protected]> Date: Tue Sep 17 16:09:49 2019 +0200 Add new examples commit d443b80 Author: Thomas Knecht <[email protected]> Date: Tue Sep 17 16:09:20 2019 +0200 Delete packages from @examples commit d967b8e Author: Thomas Knecht <[email protected]> Date: Tue Sep 17 16:06:00 2019 +0200 Adjust filter criterion in examples commit b1c8b1a Author: Thomas Knecht <[email protected]> Date: Tue Sep 17 15:39:56 2019 +0200 Add the zoo-package to Suggestions commit 55602af Author: Thomas Knecht <[email protected]> Date: Mon Sep 16 14:00:28 2019 +0200 Add position-nudgestack.R into man commit 9f6aa7d Author: Thomas Knecht <[email protected]> Date: Mon Sep 16 13:58:38 2019 +0200 Add new position_nudgestack into NAMESPACE commit 1b7c4c0 Author: Thomas Knecht <[email protected]> Date: Mon Sep 16 13:56:35 2019 +0200 Add new position to DESCRIPTION commit 6d76c3a Author: Thomas Knecht <[email protected]> Date: Mon Sep 16 13:47:58 2019 +0200 Add time series example commit f67ae70 Author: Thomas Knecht <[email protected]> Date: Tue Sep 3 09:26:32 2019 +0200 Delete emtpy rows commit 14fd33d Author: Thomas Knecht <[email protected]> Date: Tue Sep 3 09:09:06 2019 +0200 Add position_nudgestack commit 0ff81cb Merge: 7214587 10fa001 Author: Thomas Knecht <[email protected]> Date: Wed Oct 2 13:46:28 2019 +0200 Merge remote-tracking branch 'upstream/master' into Add_position_nudgestack commit 10fa001 Author: Thomas Lin Pedersen <[email protected]> Date: Tue Oct 1 11:12:59 2019 +0200 Removing direction constraint from geoms (tidyverse#3506) commit 88c5bde Author: Mine Cetinkaya-Rundel <[email protected]> Date: Tue Oct 1 09:32:08 2019 +0100 Minor updates to data docs (tidyverse#3545) commit 7214587 Author: Thomas Knecht <[email protected]> Date: Tue Oct 1 09:44:37 2019 +0200 Add news commit 28ba9bf Merge: daeb34e e688944 Author: Thomas Knecht <[email protected]> Date: Tue Oct 1 09:32:12 2019 +0200 Merge branch 'Add_position_nudgestack' of https://github.com/ThomasKnecht/ggplot2 into Add_position_nudgestack commit daeb34e Author: Thomas Knecht <[email protected]> Date: Tue Oct 1 09:20:41 2019 +0200 Style file commit e688944 Author: Thomas Knecht <[email protected]> Date: Tue Oct 1 09:20:41 2019 +0200 Style file commit 9a45cc8 Author: Thomas Lin Pedersen <[email protected]> Date: Tue Oct 1 09:03:07 2019 +0200 scale_binned (tidyverse#3096) commit 02a038e Merge: 88f4a63 bde6844 Author: Thomas Knecht <[email protected]> Date: Tue Oct 1 09:01:10 2019 +0200 Resolve conflict Merge branch 'Add_position_nudgestack' of https://github.com/ThomasKnecht/ggplot2 into Add_position_nudgestack # Conflicts: # R/position-nudgestack.R commit 88f4a63 Author: Thomas Knecht <[email protected]> Date: Mon Sep 30 14:06:24 2019 +0200 Use tsbox for converting ts object to tibble commit 752e476 Author: Thomas Knecht <[email protected]> Date: Fri Sep 27 15:58:51 2019 +0200 Bugfix commit 5271987 Author: Thomas Knecht <[email protected]> Date: Tue Oct 1 08:51:55 2019 +0200 Resolve conflict commit 771918d Author: Thomas Knecht <[email protected]> Date: Wed Sep 18 15:55:02 2019 +0200 Add tests for correct nudging and stacking commit da1e7be Author: Thomas Knecht <[email protected]> Date: Tue Sep 17 18:03:37 2019 +0200 Delete packages from example commit a1573b3 Author: Thomas Knecht <[email protected]> Date: Tue Sep 17 18:03:12 2019 +0200 Add validated svg for position_nudgestack commit 59d2b6e Author: Thomas Knecht <[email protected]> Date: Tue Sep 17 18:02:50 2019 +0200 Update vdiffr version commit 0e80c8a Author: Thomas Knecht <[email protected]> Date: Tue Sep 17 18:02:29 2019 +0200 Add test file with a doppelganger-test commit 31cc104 Author: Thomas Knecht <[email protected]> Date: Tue Sep 17 16:09:49 2019 +0200 Add new examples commit dc6b78d Author: Thomas Knecht <[email protected]> Date: Tue Sep 17 16:09:20 2019 +0200 Delete packages from @examples commit d35ea70 Author: Thomas Knecht <[email protected]> Date: Tue Sep 17 16:06:00 2019 +0200 Adjust filter criterion in examples commit 87c00fa Author: Thomas Knecht <[email protected]> Date: Tue Sep 17 15:39:56 2019 +0200 Add the zoo-package to Suggestions commit f587fb8 Author: Thomas Knecht <[email protected]> Date: Mon Sep 16 14:01:48 2019 +0200 Add description of position_nudgestack commit 327a6cd Author: Thomas Knecht <[email protected]> Date: Mon Sep 16 14:01:13 2019 +0200 Add position_nudgestack into description commit c97d54d Author: Thomas Knecht <[email protected]> Date: Mon Sep 16 14:00:28 2019 +0200 Add position-nudgestack.R into man commit 7fbc0f7 Author: Thomas Knecht <[email protected]> Date: Mon Sep 16 13:58:38 2019 +0200 Add new position_nudgestack into NAMESPACE commit 9d894a8 Author: Thomas Knecht <[email protected]> Date: Mon Sep 16 13:56:35 2019 +0200 Add new position to DESCRIPTION commit 56e9b3b Author: Thomas Knecht <[email protected]> Date: Mon Sep 16 13:47:58 2019 +0200 Add time series example commit 4535be6 Author: Mara Alexeev <[email protected]> Date: Tue Sep 3 08:26:07 2019 -0400 Clarify documentation in mpg: very minor (tidyverse#3515) * add helpful explanation of mpg$drv commit c8fa99f Author: Thomas Knecht <[email protected]> Date: Tue Sep 3 09:26:32 2019 +0200 Delete emtpy rows commit a290bb3 Author: Thomas Knecht <[email protected]> Date: Tue Sep 3 09:09:06 2019 +0200 Add position_nudgestack commit bde6844 Author: Thomas Knecht <[email protected]> Date: Mon Sep 30 14:06:24 2019 +0200 Use tsbox for converting ts object to tibble commit 0ee259c Author: bernie gray <[email protected]> Date: Mon Sep 30 06:54:57 2019 -0400 default formula argument to NULL in geom_smooth() (tidyverse#3307) commit fa000f7 Author: Dewey Dunnington <[email protected]> Date: Sun Sep 29 18:26:36 2019 -0300 Make position guides customizable (tidyverse#3398, closes tidyverse#3322) * Position guides can now be customized using the new `guide_axis()`, which can be passed to position `scale_*()` functions or via `guides()`. The new axis guide (`guide_axis()`) comes with arguments `check.overlap` (automatic removal of overlapping labels), `angle` (easy rotation of axis labels), and `n.dodge` (dodge labels into multiple rows/columns) * `CoordCartesian` gets new methods to resolve/train the new position guides commit 696fe9d Author: Thomas Knecht <[email protected]> Date: Fri Sep 27 15:58:51 2019 +0200 Bugfix commit b027238 Merge: 10b5e24 c32f856 Author: Thomas Knecht <[email protected]> Date: Wed Sep 18 16:38:27 2019 +0200 Merge branch 'Add_position_nudgestack' of https://github.com/TeddyLeeJones/ggplot2 into Add_position_nudgestack commit 10b5e24 Author: Thomas Knecht <[email protected]> Date: Wed Sep 18 15:55:02 2019 +0200 Add tests for correct nudging and stacking commit 4fb6996 Author: Thomas Knecht <[email protected]> Date: Tue Sep 17 18:03:37 2019 +0200 Delete packages from example commit 823c686 Author: Thomas Knecht <[email protected]> Date: Tue Sep 17 18:03:12 2019 +0200 Add validated svg for position_nudgestack commit e6df407 Author: Thomas Knecht <[email protected]> Date: Tue Sep 17 18:02:50 2019 +0200 Update vdiffr version commit be91893 Author: Thomas Knecht <[email protected]> Date: Tue Sep 17 18:02:29 2019 +0200 Add test file with a doppelganger-test commit f44e504 Author: Thomas Knecht <[email protected]> Date: Tue Sep 17 16:09:49 2019 +0200 Add new examples commit 3713420 Author: Thomas Knecht <[email protected]> Date: Tue Sep 17 16:09:20 2019 +0200 Delete packages from @examples commit 9291957 Author: Thomas Knecht <[email protected]> Date: Tue Sep 17 16:06:00 2019 +0200 Adjust filter criterion in examples commit ef5aef7 Author: Thomas Knecht <[email protected]> Date: Tue Sep 17 15:39:56 2019 +0200 Add the zoo-package to Suggestions commit 42c0fa3 Author: Thomas Knecht <[email protected]> Date: Mon Sep 16 14:01:48 2019 +0200 Add description of position_nudgestack commit 548f313 Author: Thomas Knecht <[email protected]> Date: Mon Sep 16 14:01:13 2019 +0200 Add position_nudgestack into description commit 7bb930c Author: Thomas Knecht <[email protected]> Date: Mon Sep 16 14:00:28 2019 +0200 Add position-nudgestack.R into man commit 9bd40d6 Author: Thomas Knecht <[email protected]> Date: Mon Sep 16 13:58:38 2019 +0200 Add new position_nudgestack into NAMESPACE commit c5022d3 Author: Thomas Knecht <[email protected]> Date: Mon Sep 16 13:56:35 2019 +0200 Add new position to DESCRIPTION commit 8572437 Author: Thomas Knecht <[email protected]> Date: Mon Sep 16 13:47:58 2019 +0200 Add time series example commit 3d61c3a Author: Thomas Knecht <[email protected]> Date: Tue Sep 3 09:26:32 2019 +0200 Delete emtpy rows commit 2782c9d Author: Thomas Knecht <[email protected]> Date: Tue Sep 3 09:09:06 2019 +0200 Add position_nudgestack commit c32f856 Author: Thomas Knecht <[email protected]> Date: Wed Sep 18 15:55:02 2019 +0200 Add tests for correct nudging and stacking commit d5c58da Author: Thomas Knecht <[email protected]> Date: Tue Sep 17 18:03:37 2019 +0200 Delete packages from example commit 015b2e3 Author: Thomas Knecht <[email protected]> Date: Tue Sep 17 18:03:12 2019 +0200 Add validated svg for position_nudgestack commit 2484f71 Author: Thomas Knecht <[email protected]> Date: Tue Sep 17 18:02:50 2019 +0200 Update vdiffr version commit e2c1fb6 Author: Thomas Knecht <[email protected]> Date: Tue Sep 17 18:02:29 2019 +0200 Add test file with a doppelganger-test commit a681f59 Author: Thomas Knecht <[email protected]> Date: Tue Sep 17 16:09:49 2019 +0200 Add new examples commit 02f6be4 Author: Thomas Knecht <[email protected]> Date: Tue Sep 17 16:09:20 2019 +0200 Delete packages from @examples commit def4755 Author: Thomas Knecht <[email protected]> Date: Tue Sep 17 16:06:00 2019 +0200 Adjust filter criterion in examples commit c1729d1 Author: Thomas Knecht <[email protected]> Date: Tue Sep 17 15:39:56 2019 +0200 Add the zoo-package to Suggestions commit 5ebe5d4 Author: Thomas Knecht <[email protected]> Date: Mon Sep 16 14:01:48 2019 +0200 Add description of position_nudgestack commit 99b4b5e Author: Thomas Knecht <[email protected]> Date: Mon Sep 16 14:01:13 2019 +0200 Add position_nudgestack into description commit 971b110 Author: Thomas Knecht <[email protected]> Date: Mon Sep 16 14:00:28 2019 +0200 Add position-nudgestack.R into man commit e5e91ea Author: Thomas Knecht <[email protected]> Date: Mon Sep 16 13:58:38 2019 +0200 Add new position_nudgestack into NAMESPACE commit fedef93 Author: Thomas Knecht <[email protected]> Date: Mon Sep 16 13:56:35 2019 +0200 Add new position to DESCRIPTION commit bcc75a3 Author: Thomas Knecht <[email protected]> Date: Mon Sep 16 13:47:58 2019 +0200 Add time series example commit 23e3241 Author: Mara Alexeev <[email protected]> Date: Tue Sep 3 08:26:07 2019 -0400 Clarify documentation in mpg: very minor (tidyverse#3515) * add helpful explanation of mpg$drv commit 01d7db0 Author: Thomas Knecht <[email protected]> Date: Tue Sep 3 09:26:32 2019 +0200 Delete emtpy rows commit a486906 Author: Thomas Knecht <[email protected]> Date: Tue Sep 3 09:09:06 2019 +0200 Add position_nudgestack

lock · 2020-04-02T15:00:41Z

This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/

default formula argument to NULL in geom_smooth(); closes #3205

508e1bc

bfgray3 added 4 commits May 13, 2019 20:39

remove news bullet for now since deadline for release has passed

4bb34e3

handle NULL formulas more carefully in geom_smooth()

04b3327

respect input formuals in geom_smooth()

bf963db

add parens around formula on rhs of %||%

c4ce320

thomasp85 changed the title ~~default formula argument to NULL in geom_smooth(); closes 3205~~ default formula argument to NULL in geom_smooth() Jun 3, 2019

hadley reviewed Jun 4, 2019

View reviewed changes

only set formula once the method is known

c9644c3

hadley reviewed Jun 5, 2019

View reviewed changes

bfgray3 added 2 commits June 13, 2019 23:16

refactor

0c2826b

tweak formula message for geom_smooth

5910606

hadley reviewed Jun 14, 2019

View reviewed changes

bfgray3 added 4 commits June 15, 2019 21:37

clean up smoothing message

99e9ad2

merge in upstream master

68e8a30

fix backwards compatibility of method = 'auto'

b4d92e7

code aesthetics

3aaa53e

hadley approved these changes Jun 16, 2019

View reviewed changes

thomasp85 added 2 commits September 30, 2019 11:53

Fix styling

ca5ba90

Merge branch 'master' of https://github.com/tidyverse/ggplot2 into bf…

6a97cd6

…gray3-geom-smooth-formula

thomasp85 merged commit 0ee259c into tidyverse:master Sep 30, 2019

lock bot locked and limited conversation to collaborators Apr 2, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

default formula argument to NULL in geom_smooth() #3307

default formula argument to NULL in geom_smooth() #3307

bfgray3 commented May 7, 2019 •

edited by thomasp85

Loading

clauswilke commented May 7, 2019

hadley Jun 4, 2019

bfgray3 Jun 5, 2019

hadley Jun 5, 2019

hadley Jun 5, 2019

hadley Jun 5, 2019

hadley Jun 14, 2019

hadley Jun 14, 2019

hadley Jun 14, 2019

hadley Jun 14, 2019

thomasp85 commented Sep 27, 2019

hadley commented Sep 27, 2019

lock bot commented Apr 2, 2020

default formula argument to NULL in geom_smooth() #3307

default formula argument to NULL in geom_smooth() #3307

Conversation

bfgray3 commented May 7, 2019 • edited by thomasp85 Loading

clauswilke commented May 7, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

thomasp85 commented Sep 27, 2019

hadley commented Sep 27, 2019

lock bot commented Apr 2, 2020

bfgray3 commented May 7, 2019 •

edited by thomasp85

Loading