Fix limits argument of scale_{colour,fill}_manual() #3685
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #3262
At the time of #3262 (comment), I thought this should be fixed in
manual_scale()
. But it turns out this is a bug ofScaleDiscrete
; the if block below useslimits
only whenpal
is named:ggplot2/R/scale-.r
Lines 778 to 783 in e6cbcc1
I see no reason to ignore
limits
here. (This code has been here sinceScale
was first implemented (1877b6d), so there might have been some limitation?) This PR fixes the issue by limiting thepal
first before matching it against the supplied values.