Fix blank strip text with multilayered strips #4384
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to fix #4050, wherein an error occurs in
facet_grid()
when the strip text is a blank element and there are two variables determining the strips. This also caused an inelegant warning infacet_wrap()
that should now also be remedied.Instead of returning an
n
bym
matrix ofzeroGrob
s, theassemble_strips()
internal function now returns ann
-length list ofzeroGrob
s regardless ofm
. This then satisfies theFacetWrap/Grid$draw_panel()
methods' assumption that the length of the strip-grobs is equal to the number of panels (forfacet_wrap()
) or columns/rows (forfacet_grid()
).The following should now work without warnings or errors: