Make annotate_logticks coord_flip-aware #4431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -126,13 +126,15 @@ GeomLogticks <- ggproto("GeomLogticks", Geom, | |||
| mid = unit(0.2, "cm"), long = unit(0.3, "cm")) | |||
| { | |||
| ticks <- list() | |||
| flipped <- inherits(coord, "CoordFlip") | |||
There was a problem hiding this comment.
This feels a bit too specific to this problem. Are there any other way to check if the coord is flipped? (I guess the answer is no, but let me just confirm...)
There was a problem hiding this comment.
The answer is no :-)... We have these annoying specific logic pertaining to coord_flip around the code base and there is not really much to do about it at this time
We can discuss a more throughout fix at a later stage but that is beyond this fix
There was a problem hiding this comment.
I see, thanks for clarifying.
yutannihilation
approved these changes
Apr 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #3954
This PR ensures that
annotate_logticks()works in the presence ofcoord_flip(). It does so by flipping around the ranges and aesthetic names.Important notice: With this PR,
sides = "b"will not get translated tosides = "l". Since thesidesargument is positional and not tied to aesthetic names it makes sense to me to leave it alone