locale(encoding=) should not strictly rely on iconvlist() #1537
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
check_encoding()
auxiliary function verifies the specified inputencoding
viaiconvlist()
readr/R/locale.R
Line 132 in e529cb2
and rejects any non-listed encoding.
Unfortunately, this unnecessarily breaks
locale()
on platforms whereiconvlist()
is incomplete. As?iconvlist
saysI'd suggest to always accept the portable encodings "latin1" and "UTF-8" and otherwise only give a
warning
rather thanstop
if the specified encoding is not found.This PR also fixes long-standing package check failures on Alpine Linux, e.g.,