Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide rbind method #34

Open
hadley opened this issue Mar 7, 2016 · 18 comments · May be fixed by #909
Open

Provide rbind method #34

hadley opened this issue Mar 7, 2016 · 18 comments · May be fixed by #909
Milestone

Comments

@hadley
Copy link
Member

hadley commented Mar 7, 2016

That uses dplyr::bind_rows().

Moved from tidyverse/dplyr#1385

@krlmlr krlmlr added this to the 2.0 milestone Mar 7, 2016
@krlmlr
Copy link
Member

krlmlr commented Mar 7, 2016

Does this mean copying the bind_rows() implementation from dplyr? This seems to need at least Collecter, SlicingIndex and set_rownames().

@hadley
Copy link
Member Author

hadley commented Mar 7, 2016

Yeah, I'm not sure how to deal with that. One option would be to add a dplyr dependency to tibble (just a suggest), but that seems suboptimal.

@krlmlr
Copy link
Member

krlmlr commented Mar 7, 2016

I think I'll add rbind.tbl_df() and make sure it behaves like the dplyr equivalent.

@hadley
Copy link
Member Author

hadley commented Mar 18, 2016

I think we can leave this for now.

@hadley hadley closed this as completed Mar 18, 2016
@gavinsimpson
Copy link

gavinsimpson commented May 27, 2016

Can this be reconsidered/reopened? Part of the justification for tibble is so you don't need all of dplyr just to have the data frame goodness. As such tibble should provide a suite of tools for working with tibbles or tbl_dfs.

An rbind.tbl_df() would be a most useful addition to this package

@hadley
Copy link
Member Author

hadley commented May 27, 2016

Not in near future - there is a lot of code powering bind rows that we'd need to duplicate. All the variable coercion stuff is complicated.

@gavinsimpson
Copy link

Is it being considered for the longer term future? Closing this issue gave me the impression this wasn't something you were going to deal with.

I have no doubt this is complicated; if it were easy I suspect it would have been done by now.

@hadley
Copy link
Member Author

hadley commented May 27, 2016

In the long long term I'd like to move data frame stuff related here but it's probably at least a year away

@krlmlr
Copy link
Member

krlmlr commented Jan 26, 2017

I think we could do just what data.table does -- they're patching rbind.data.frame(): tidyverse/dplyr#606 (comment).

@krlmlr
Copy link
Member

krlmlr commented Apr 17, 2017

Did we agree to not patch fix rbind() and cbind()?

@hadley
Copy link
Member Author

hadley commented Apr 17, 2017

I'd prefer not to mess with base R functions

@krlmlr krlmlr closed this as completed Apr 17, 2017
@github-actions
Copy link
Contributor

This old thread has been automatically locked. If you think you have found something related to this, please open a new issue and link to this old issue if necessary.

@github-actions github-actions bot locked and limited conversation to collaborators Dec 13, 2020
@krlmlr
Copy link
Member

krlmlr commented Jul 18, 2021

Let's retry, also with cbind(), now that we have vctrs.

@krlmlr krlmlr reopened this Jul 18, 2021
@krlmlr krlmlr modified the milestones: 1.2, 3.1.4 Jul 18, 2021
@hadley
Copy link
Member Author

hadley commented Jul 18, 2021

👍

@krlmlr krlmlr modified the milestones: 3.1.4, 3.1.3 Jul 20, 2021
@krlmlr
Copy link
Member

krlmlr commented Jul 20, 2021

Things appear to have changed for R 4.0.0, the relevant FAQ in data.table was updated. Are we ok with a solution that works only in R 4.0.0 now, should we postpone until the tidyverse requires R 4.0.0?

@hadley
Copy link
Member Author

hadley commented Jul 20, 2021

I think it's fine to add a solution that only works in 4.0.0 and up. That will help the majority of users.

@krlmlr krlmlr linked a pull request Jul 21, 2021 that will close this issue
@krlmlr
Copy link
Member

krlmlr commented Jul 21, 2021

Done. I'll release to CRAN without it, we might want to do revdepchecks because users might rely on downcasting to data frames.

@krlmlr krlmlr modified the milestones: 3.1.3, 3.1.4 Jul 21, 2021
@krlmlr krlmlr removed this from the 3.1.4 milestone Aug 1, 2021
@krlmlr
Copy link
Member

krlmlr commented Oct 25, 2021

Do we still want this, given the complexities discussed in #909?

@DavisVaughan suggests to

link to vec_rbind() in the tibble::add_row() documentation. i.e. "If you would like to row bind multiple data frames together, see..."

Similar for vec_cbind() and tibble::add_column().

@tidyverse tidyverse unlocked this conversation Oct 26, 2021
@krlmlr krlmlr added this to the 3.1.7 milestone Dec 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants