This repository has been archived by the owner on Mar 27, 2023. It is now read-only.
feat: use same param file for Error Monitor #240
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
Related Links
Description
Change
system_launch
so thatsystem_error_monitor
uses the same configuration file for both the real car and the simulator.Background
system_error_monitor
uses different configuration for the real car(autoware.launch) and for the simulator(planning_simulator.launch)ERROR
andWARN
.This PR
ignore_missing_diagnostics
flag ofsystem_error_monitor
, unify configuration file for both the real car and the simulator.system_error_monitor
ignorehalt
instead of treating them as errors.system_monitor
during simulationsystem_monitor
behalt
instead oferror
and makesystem_error_monitor
ignore it.Cocern
halt
status, real halts of diagnostics cannot be detected on the simulatorReview Procedure
Remarks
Pre-Review Checklist for the PR Author
PR Author should check the checkboxes below when creating the PR.
Checklist for the PR Reviewer
Reviewers should check the checkboxes below before approval.
Post-Review Checklist for the PR Author
PR Author should check the checkboxes below before merging.
CI Checks