Skip to content
This repository has been archived by the owner on Mar 27, 2023. It is now read-only.

feat: move empty_objects_publisher #259

Merged
merged 1 commit into from
Apr 4, 2022

Conversation

tkimura4
Copy link
Collaborator

@tkimura4 tkimura4 commented Apr 4, 2022

Signed-off-by: tomoya.kimura [email protected]

PR Type

  • Improvement

Related Links

autowarefoundation/autoware.universe#613

Description

move the description of empty_objects_publisher from dummy_perception_publisher.launch to simulator.launch

Review Procedure

Launch planning simulator with the option perception/enable_object_recognition:=false
Confirm that the empty_objects_publisher node exists.
$ros2 node info /perception/object_recognition/empty_objects_publisher

Remarks

Pre-Review Checklist for the PR Author

PR Author should check the checkboxes below when creating the PR.

Checklist for the PR Reviewer

Reviewers should check the checkboxes below before approval.

  • Commits are properly organized and messages are according to the guideline
  • Code follows coding guidelines
  • (Optional) Unit tests have been written for new behavior
  • PR title describes the changes

Post-Review Checklist for the PR Author

PR Author should check the checkboxes below before merging.

  • All open points are addressed and tracked via issues or tickets
  • Write release notes

CI Checks

  • Build and test for PR: Required to pass before the merge.
  • Check spelling: NOT required to pass before the merge. It is up to the reviewer(s). See here if you want to add some words to the spell check dictionary.

Copy link
Contributor

@takayuki5168 takayuki5168 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tkimura4 tkimura4 merged commit fcab1f7 into tier4/universe Apr 4, 2022
@tkimura4 tkimura4 deleted the feature/move_empty_object_publisher branch April 4, 2022 12:32
@takayuki5168
Copy link
Contributor

Please make sure to write release note if you have not written yet.

s-azumi pushed a commit to s-azumi/autoware_launch that referenced this pull request Apr 21, 2022
Bumps [streetsidesoftware/cspell-action](https://github.com/streetsidesoftware/cspell-action) from 1.1.1 to 1.2.5.
- [Release notes](https://github.com/streetsidesoftware/cspell-action/releases)
- [Changelog](https://github.com/streetsidesoftware/cspell-action/blob/main/CHANGELOG.md)
- [Commits](streetsidesoftware/cspell-action@v1.1.1...v1.2.5)

---
updated-dependencies:
- dependency-name: streetsidesoftware/cspell-action
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
tier4-autoware-public-bot bot pushed a commit that referenced this pull request Mar 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants