Skip to content
This repository has been archived by the owner on Mar 27, 2023. It is now read-only.

feat(intersection): consider state transit margin time in collision detection #728

Merged
merged 4 commits into from
Jan 24, 2023
Merged

feat(intersection): consider state transit margin time in collision detection #728

merged 4 commits into from
Jan 24, 2023

Conversation

soblin
Copy link
Contributor

@soblin soblin commented Jan 23, 2023

PR Type

  • Improvement

Related Links

feature PR: autowarefoundation/autoware.universe#2719

https://tier4.atlassian.net/browse/T4PB-24144

Description

Improved collision detection to be more stable than before. Parameter values are mainly determined based on experiment.

Review Procedure

All scenarios passed without any retrial.

https://evaluation.tier4.jp/evaluation/reports/20c3d884-d33d-5361-a88a-953038dd13dc?project_id=prd_jt

Pre-Review Checklist for the PR Author

PR Author should check the checkboxes below when creating the PR.

Checklist for the PR Reviewer

Reviewers should check the checkboxes below before approval.

  • Commits are properly organized and messages are according to the guideline
  • Code follows coding guidelines
  • (Optional) Unit tests have been written for new behavior
  • PR title describes the changes

Post-Review Checklist for the PR Author

PR Author should check the checkboxes below before merging.

  • All open points are addressed and tracked via issues or tickets
  • Write release notes

CI Checks

  • Build and test for PR: Required to pass before the merge.
  • Check spelling: NOT required to pass before the merge. It is up to the reviewer(s). See here if you want to add some words to the spell check dictionary.

@soblin soblin changed the title Feat/intersection improve ego vel prediction feat(intersection): consider state transit margin time in collision detection Jan 23, 2023
Copy link
Contributor

@takayuki5168 takayuki5168 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@takayuki5168
Copy link
Contributor

@soblin Please make a PR to awf/autoware_launch as well.

@soblin
Copy link
Contributor Author

soblin commented Jan 24, 2023

@takayuki5168 PR to awf/autoware_launch is here: autowarefoundation/autoware_launch#181

@soblin soblin merged commit 58678b9 into tier4:awf-latest Jan 24, 2023
@soblin soblin deleted the feat/intersection-improve-ego-vel-prediction branch January 24, 2023 14:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants