Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: sync files #150

Merged
merged 2 commits into from
Oct 28, 2022
Merged

chore: sync files #150

merged 2 commits into from
Oct 28, 2022

Conversation

system-tools-actions-public[bot]
Copy link
Contributor

@system-tools-actions-public system-tools-actions-public bot commented Sep 26, 2022

Skipped

Added

Changed

  • .markdown-link-check.json
  • .github/workflows/deploy-docs.yaml
  • .cspell.json

Not changed

  • .github/dependabot.yaml
  • .github/workflows/pre-commit.yaml
  • .github/workflows/pre-commit-optional.yaml
  • .github/workflows/semantic-pull-request.yaml
  • .github/workflows/spell-check-differential.yaml
  • .markdownlint.yaml
  • .pre-commit-config-optional.yaml
  • .prettierignore
  • .prettierrc.yaml
  • .yamllint.yaml
  • .github/workflows/github-release.yaml
  • cliff.toml
  • .github/workflows/delete-closed-pr-docs.yaml

Deleted

Not found

Signed-off-by: GitHub <[email protected]>
@@ -40,4 +40,3 @@ jobs:
with:
token: ${{ secrets.GITHUB_TOKEN }}
latest: ${{ github.event_name != 'pull_request_target' && github.ref_name == github.event.repository.default_branch }}
mkdocs-requirements-txt: ./mkdocs-requirements.txt
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pr cannot be merged because of this line.
After merging autowarefoundation/autoware-github-actions#190, sync-files can be merged because mkdocs-requirements.txt becomes not necessary

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hsgwa
I issued the same pull request in the past. @kenji-miyake suggested me to add a function to customize project-dedicated mkdocs-requirements-txt.
autowarefoundation/autoware-github-actions#163

I think that CARET project has to take care of this sync-files, so that we have to exclude or suppress this deletion.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

related: #175

@takam5f2 takam5f2 merged commit 2f11d31 into main Oct 28, 2022
@takam5f2 takam5f2 deleted the sync-files branch October 28, 2022 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants