Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update sensor models and pointcloud types #171

Merged
merged 7 commits into from
Jul 5, 2024

Conversation

mojomex
Copy link
Collaborator

@mojomex mojomex commented Jun 27, 2024

PR Type

  • Improvement

Description

Pointcloud types were not up-to-date anymore and SRR520 was missing. Also renamed PandarE4X to OT128 in the docs.
Added a reference to the supported sensors page on the usage page for an easier getting-started experience.

Pre-Review Checklist for the PR Author

PR Author should check the checkboxes below when creating the PR.

  • Assign PR to reviewer

Checklist for the PR Reviewer

Reviewers should check the checkboxes below before approval.

  • Commits are properly organized and messages are according to the guideline
  • (Optional) Unit tests have been written for new behavior
  • PR title describes the changes

Post-Review Checklist for the PR Author

PR Author should check the checkboxes below before merging.

  • All open points are addressed and tracked via issues or tickets

CI Checks

  • Build and test for PR: Required to pass before the merge.

@mojomex mojomex requested review from amc-nu and drwnz June 27, 2024 07:04
@mojomex mojomex self-assigned this Jun 27, 2024
@mojomex mojomex changed the base branch from main to develop June 27, 2024 07:04
@mojomex mojomex changed the title dosc: update sensor models and pointcloud types docs: update sensor models and pointcloud types Jun 27, 2024
Copy link
Collaborator

@drwnz drwnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggested wording changes, expecting that it is assumed the fields are referring to a (singular) point.

docs/point_types.md Outdated Show resolved Hide resolved
docs/point_types.md Outdated Show resolved Hide resolved
docs/point_types.md Outdated Show resolved Hide resolved
docs/point_types.md Outdated Show resolved Hide resolved
docs/point_types.md Outdated Show resolved Hide resolved
docs/point_types.md Outdated Show resolved Hide resolved
docs/point_types.md Outdated Show resolved Hide resolved
docs/point_types.md Outdated Show resolved Hide resolved
docs/point_types.md Outdated Show resolved Hide resolved
docs/point_types.md Outdated Show resolved Hide resolved
docs/point_types.md Outdated Show resolved Hide resolved
@mojomex mojomex requested a review from drwnz June 28, 2024 05:54
Copy link
Collaborator

@drwnz drwnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@drwnz drwnz merged commit e58d5a7 into tier4:develop Jul 5, 2024
10 checks passed
@mojomex mojomex deleted the doc-improvements branch July 5, 2024 08:16
@mojomex mojomex mentioned this pull request Jul 18, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants