Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(hesai): correctly handle return mode when updating parameters #185

Merged
merged 1 commit into from
Aug 26, 2024

Conversation

mojomex
Copy link
Collaborator

@mojomex mojomex commented Aug 26, 2024

PR Type

  • Bug Fix

Description

When setting parameters during runtime, e.g. with ros2 param set, the return mode parameter was parsed with the wrong function, resulting in most return modes not being accepted. this PR fixes this.

Review Procedure

Confirm all supported return modes can be set during runtime.

Pre-Review Checklist for the PR Author

PR Author should check the checkboxes below when creating the PR.

  • Assign PR to reviewer

Checklist for the PR Reviewer

Reviewers should check the checkboxes below before approval.

  • Commits are properly organized and messages are according to the guideline
  • (Optional) Unit tests have been written for new behavior
  • PR title describes the changes

Post-Review Checklist for the PR Author

PR Author should check the checkboxes below before merging.

  • All open points are addressed and tracked via issues or tickets

CI Checks

  • Build and test for PR: Required to pass before the merge.

@mojomex mojomex self-assigned this Aug 26, 2024
@mojomex
Copy link
Collaborator Author

mojomex commented Aug 26, 2024

Because this is a small and obvious change, I will merge it myself 🙇

@mojomex mojomex merged commit 95c3709 into tier4:develop Aug 26, 2024
10 checks passed
@mojomex mojomex deleted the fix-hesai-return-mode-param branch August 26, 2024 07:39
@mojomex mojomex mentioned this pull request Aug 30, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant