Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pandar_msgs): fix typo #64

Merged
merged 1 commit into from
Aug 31, 2023
Merged

fix(pandar_msgs): fix typo #64

merged 1 commit into from
Aug 31, 2023

Conversation

esteve
Copy link
Contributor

@esteve esteve commented Aug 30, 2023

PR Type

  • Bug Fix

Related Links

Description

Fixes a typo (Heisai vs Hesai)

Review Procedure

Remarks

Pre-Review Checklist for the PR Author

PR Author should check the checkboxes below when creating the PR.

  • Assign PR to reviewer

Checklist for the PR Reviewer

Reviewers should check the checkboxes below before approval.

  • Commits are properly organized and messages are according to the guideline
  • (Optional) Unit tests have been written for new behavior
  • PR title describes the changes

Post-Review Checklist for the PR Author

PR Author should check the checkboxes below before merging.

  • All open points are addressed and tracked via issues or tickets

CI Checks

  • Build and test for PR: Required to pass before the merge.

Signed-off-by: Esteve Fernandez <[email protected]>
@codecov-commenter
Copy link

Codecov Report

Patch coverage has no change and project coverage change: +2.59% 🎉

Comparison is base (eb76d55) 13.35% compared to head (aaac9b7) 15.95%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #64      +/-   ##
==========================================
+ Coverage   13.35%   15.95%   +2.59%     
==========================================
  Files         111       51      -60     
  Lines       10989     8529    -2460     
  Branches     1725     1664      -61     
==========================================
- Hits         1468     1361     -107     
+ Misses       8345     6016    -2329     
+ Partials     1176     1152      -24     
Flag Coverage Δ
differential 15.95% <ø> (?)
total ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 60 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@drwnz drwnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@drwnz drwnz merged commit fa5b38a into tier4:main Aug 31, 2023
7 checks passed
@esteve esteve deleted the fix-typo branch September 1, 2023 05:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants