test(nebula_tests): remove designated initializers

[mojomex]

PR Type

• Improvement

Related Links

Description

This PR gets rid of the designated initializers in the nebula_tests package which caused compiler warnings as this feature is only supported from C++20 onward.

Also made tiny changes to other parts of the tests that raised warnings (unused parameters etc.). There are now no warnings at all when compiling the tests.

Review Procedure

colcon build --packages-up-to nebula_tests
colcon test --event-handlers console_cohesion+ --packages-select nebula_tests

Remarks

Pre-Review Checklist for the PR Author

PR Author should check the checkboxes below when creating the PR.

• Assign PR to reviewer

Checklist for the PR Reviewer

Reviewers should check the checkboxes below before approval.

• Commits are properly organized and messages are according to the guideline
• (Optional) Unit tests have been written for new behavior
• PR title describes the changes

Post-Review Checklist for the PR Author

PR Author should check the checkboxes below before merging.

• All open points are addressed and tracked via issues or tickets

CI Checks

• Build and test for PR: Required to pass before the merge.

[drwnz]

LGTM!