feat(launch): adding v4l2 buffer timestamp and image_transport options to launch file #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yuxuan Liu <[email protected]>
|
By the way, I think it is not really good that I can directly merge the PR myself. I will wait for a review first.. |
Signed-off-by: Yuxuan Liu <[email protected]>
Owen-Liuyuxuan
changed the title
drwnz
requested changes
Jul 10, 2024
drwnz
reviewed
Jul 10, 2024
Signed-off-by: Yuxuan Liu <[email protected]>
|
Thank you for the review. I updated the documents. |
drwnz
approved these changes
Jul 10, 2024
drwnz
reviewed
Jul 10, 2024
Signed-off-by: Yuxuan Liu <[email protected]>
TomohitoAndo
pushed a commit
that referenced
this pull request
Sep 6, 2024
feat(launch): adding v4l2 buffer timestamp and image_transport options to launch file
TomohitoAndo
added a commit
that referenced
this pull request
Sep 6, 2024
feat(launch): adding v4l2 buffer timestamp and image_transport options to launch file Co-authored-by: David Wong <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We have PR #9 introducing
use_v4l2_buffer_timestampsflag into the node and PR #14 introducinguse_image_transportflag into the node. But They do not appear in the launch file, which could confuse users.