Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/traffic simulator/follow trajectory action #1022

Merged
merged 17 commits into from
Aug 1, 2023
Merged

Feature/traffic simulator/follow trajectory action #1022

merged 17 commits into from
Aug 1, 2023

Conversation

yamacir-kit
Copy link
Collaborator

@yamacir-kit yamacir-kit commented Jun 26, 2023 •
edited
Loading

Types of PR

  • New Features
  • Upgrade of existing features
  • Bugfix

Description

  • Made the body of FollowTrajectoryAction independent as a free function.
  • Changed data type defined in data_type/follow_trajectory.hpp to ROS 2 message type (traffic_simulator_msgs).

@yamacir-kit yamacir-kit added the feature New feature or request label Jun 26, 2023
@yamacir-kit yamacir-kit self-assigned this Jun 26, 2023
@github-actions
Copy link

github-actions bot commented Jul 24, 2023 •
edited
Loading

This PR may breaks the interface to external services! Please see https://tier4.atlassian.net/wiki/spaces/S/pages/1984987364

@yamacir-kit yamacir-kit force-pushed the feature/traffic_simulator/follow-trajectory-action branch from 83b4015 to 9cf3742 Compare July 26, 2023 06:09
@yamacir-kit
Copy link
Collaborator Author

yamacir-kit commented Jul 26, 2023 •
edited
Loading

Note: I forgot to include the newly added file in the commit, so I fixed it with git commit --amend and did a force-push. (I prioritized matching the commit message and the contents of the commit rather than avoiding force push)

@github-actions
Copy link

This PR may breaks the interface to external services! Please see https://tier4.atlassian.net/wiki/spaces/S/pages/1984987364

@yamacir-kit yamacir-kit marked this pull request as ready for review August 1, 2023 08:33
@hakuturu583 hakuturu583 merged commit a101ed2 into master Aug 1, 2023
10 checks passed
@hakuturu583 hakuturu583 deleted the feature/traffic_simulator/follow-trajectory-action branch August 1, 2023 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hakuturu583 hakuturu583 hakuturu583 approved these changes

Assignees

@yamacir-kit yamacir-kit

Labels
feature New feature or request interface breaking
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yamacir-kit @hakuturu583