Support for de-spawning entity #1096
Merged
+548
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR may breaks the interface to external services! Please see https://tier4.atlassian.net/wiki/spaces/S/pages/1984987364 |
f0reachARR
force-pushed
the
feature/deleted-entity
branch
from
b55a6d9
to
e070986
Compare
|
Changes of interface are planned to be reverted |
f0reachARR
force-pushed
the
feature/deleted-entity
branch
2 times, most recently
from
5c97887
to
500f619
Compare
f0reachARR
force-pushed
the
feature/deleted-entity
branch
from
500f619
to
b560d8c
Compare
f0reachARR
force-pushed
the
feature/deleted-entity
branch
from
b560d8c
to
b359815
Compare
HansRobo
approved these changes
Oct 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of PR
Link to the issue
Description
Support
DeleteEntityActionby replacing the entity with empty object.Thanks to empty object, the changeset is small
How to review this PR.
Currently, no scenario use
DeleteEntityAction, so I addeddelete.yaml.As behavior was changed, regression test is needed.
Others