-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reducing build time of openscenario_interpreter
by utilizing precompiled headers
#1370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Checklist for reviewers ☑️All references to "You" in the following text refer to the code reviewer.
|
shouth
added
small feature
improvement
wait for regression test
bump patch
If this pull request merged, bump patch version of the scenario_simulator_v2
labels
Sep 17, 2024
yamacir-kit
requested changes
Sep 25, 2024
I have confirmed that the openscenario_interpreter build is 3 minutes shorter in GitHub Actions as well. |
I sorted precompiled header list. |
Quality Gate passedIssues Measures |
yamacir-kit
approved these changes
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bump patch
If this pull request merged, bump patch version of the scenario_simulator_v2
improvement
small feature
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Abstract
This pull request reduces the build time for
opendscenario_interpreter
by using precompiled headers.Background
In the current codebase, large header files were being parsed multiple times and cause longer build time. To address this, I used Clang's
-ftime-trace
to identify the headers that were taking the most time to parse and updatedCMakeLists.txt
to ensure they are precompiled.Details
In my environment, the build time of
openscenario_interpreter
was reduced from 9m 21s to 7m 59s with 12 parallel builds.References
N/A
Destructive Changes
N/A
Known Limitations
N/A