Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code Optimization and Refactoring #1430

Merged
merged 7 commits into from
Nov 6, 2024
Merged

Code Optimization and Refactoring #1430

merged 7 commits into from
Nov 6, 2024

Conversation

TakanoTaiga
Copy link
Member

@TakanoTaiga TakanoTaiga commented Oct 29, 2024

Abstract

This pull request introduces code optimizations and improvements, including the removal of unused variables, added override qualifiers, standardization of declarations, and adjustments to lambda captures and explicit casts.

Background

To improve code clarity, performance, and maintainability, minor refactors and cleanup were conducted. These changes aim to ensure consistency and efficiency in the codebase.

Details

  • Unused Variable Removal: Unused variables were removed to optimize memory usage.
  • Inline Directives: Added missing inline directives where needed.
  • Virtual Destructor: A virtual destructor was added for polymorphic classes to ensure proper resource management.
  • Lambda Capture Adjustments: Unnecessary captures in lambdas were removed for performance.
  • Override Qualifiers: Missing override qualifiers were added to functions to improve code clarity.
  • Standardizing Declarations: Standardized declaration patterns for better readability and consistency.
  • Explicit Casts: Implemented explicit casts to prevent implicit conversion issues.

References

This PR fixes errors or warnings that appeared during Clang builds.

Destructive Changes

N/A

Known Limitations

N/A

@TakanoTaiga TakanoTaiga added the bump patch If this pull request merged, bump patch version of the scenario_simulator_v2 label Oct 29, 2024
@TakanoTaiga TakanoTaiga self-assigned this Oct 29, 2024
Copy link

github-actions bot commented Oct 29, 2024

Checklist for reviewers ☑️

All references to "You" in the following text refer to the code reviewer.

  • Is this pull request written in a way that is easy to read from a third-party perspective?
  • Is there sufficient information (background, purpose, specification, algorithm description, list of disruptive changes, and migration guide) in the description of this pull request?
  • If this pull request contains a destructive change, does this pull request contain the migration guide?
  • Labels of this pull request are valid?
  • All unit tests/integration tests are included in this pull request? If you think adding test cases is unnecessary, please describe why and cross out this line.
  • The documentation for this pull request is enough? If you think adding documents for this pull request is unnecessary, please describe why and cross out this line.

Copy link

sonarcloud bot commented Oct 29, 2024

@TakanoTaiga TakanoTaiga marked this pull request as ready for review October 29, 2024 14:09
@hakuturu583 hakuturu583 self-requested a review November 5, 2024 04:47
@hakuturu583 hakuturu583 merged commit 866a553 into master Nov 6, 2024
19 checks passed
@github-actions github-actions bot deleted the fix/refactor-code branch November 6, 2024 04:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bump patch If this pull request merged, bump patch version of the scenario_simulator_v2 wait for regression test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants