Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix/sonor-cloud-issue-4 #1434

Closed
wants to merge 10 commits into from
Closed

fix/sonor-cloud-issue-4 #1434

wants to merge 10 commits into from

Conversation

TakanoTaiga
Copy link
Member

Description

Please check examples and comment out this sentence. Minimal example is here and detailed example is here

Abstract

[Required] This section is required, keep it short, clear and to the point.
Delete this sentence and explain this pull request shortly.

Background

[Optional] If there is no background information that needs explanation (e.g., just a typo correction, etc.), you can skip this section.
Delete this sentence and explain the circumstances that led to this pull request being sent.

Details

[Optional] If there are only differences whose effects are so obvious that no explanation is needed, or if there are no differences in the code (e.g., documentation additions), you can skip this section.
Delete this sentence and describe this pull request.
For example, it is desirable to describe the specifications of added functions, and detailed explanations of bugs that have been fixed.

References

Destructive Changes

[Optional] If no destructive change exists, you can skip this section.
Include a description of the changes and a migration guide and send the pull request with a bump major label. (Example : #1139)
Otherwise, skip the "Destructive Changes" section and make sure this pull request is labeled bump minor or bump patch.

Known Limitations

[Optional] If there are no known limitations that you can think of, you can skip this section. If there are any limitations on the features or fixes added by this pull request, delete this sentence and clearly describe them.
For example, the lane matching algorithm currently (1/25/2024) employed is unable to match Entity that is heavily tilted with respect to the lane, and it is difficult to throw an exception.
If the developer is aware of the existence of such problems or limitations, describe them in detail. The problems or limitation should be listed as an Issue on GitHub and a link to it should be provided in this section.

@TakanoTaiga TakanoTaiga added the bump patch If this pull request merged, bump patch version of the scenario_simulator_v2 label Oct 31, 2024
@TakanoTaiga TakanoTaiga self-assigned this Oct 31, 2024
Copy link

Checklist for reviewers ☑️

All references to "You" in the following text refer to the code reviewer.

  • Is this pull request written in a way that is easy to read from a third-party perspective?
  • Is there sufficient information (background, purpose, specification, algorithm description, list of disruptive changes, and migration guide) in the description of this pull request?
  • If this pull request contains a destructive change, does this pull request contain the migration guide?
  • Labels of this pull request are valid?
  • All unit tests/integration tests are included in this pull request? If you think adding test cases is unnecessary, please describe why and cross out this line.
  • The documentation for this pull request is enough? If you think adding documents for this pull request is unnecessary, please describe why and cross out this line.

std::vector<geometry_msgs::msg::Point> getPointsFromBbox(
traffic_simulator_msgs::msg::BoundingBox bounding_box, double width_extension_right = 0.0,
const traffic_simulator_msgs::msg::BoundingBox bounding_box, double width_extension_right = 0.0,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
const traffic_simulator_msgs::msg::BoundingBox bounding_box, double width_extension_right = 0.0,
const traffic_simulator_msgs::msg::BoundingBox bounding_box, const double width_extension_right = 0.0,

@TakanoTaiga TakanoTaiga closed this Nov 7, 2024
@TakanoTaiga TakanoTaiga deleted the fix/sonor-cloud-issue-4 branch November 7, 2024 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bump patch If this pull request merged, bump patch version of the scenario_simulator_v2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants