Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tier4_system_msgs): add mode change available message #61

Merged
merged 3 commits into from
Oct 24, 2022

Conversation

isamu-takagi
Copy link
Contributor

@isamu-takagi isamu-takagi commented Oct 19, 2022

Related Links

autowarefoundation/autoware.universe#2120

Description

Remarks

Pre-Review Checklist for the PR Author

PR Author should check the checkboxes below when creating the PR.

  • Code is properly formatted
  • Assign PR to reviewer

Checklist for the PR Reviewer

Reviewers should check the checkboxes below before approval.

  • Commits are properly organized and messages are according to the guideline
  • Code is properly formatted
  • PR title describes the changes

Post-Review Checklist for the PR Author

PR Author should check the checkboxes below before merging.

  • All open points are addressed and tracked via issues or tickets
  • Write release notes

CI Checks

  • Build and test for PR: Required to pass before the merge.
  • Check spelling: NOT required to pass before the merge. It is up to the reviewer(s). See here if you want to add some words to the spell check dictionary.

@isamu-takagi isamu-takagi self-assigned this Oct 19, 2022
Signed-off-by: Takagi, Isamu <[email protected]>
@isamu-takagi isamu-takagi changed the title Feature/launch state feat(tier4_system_msgs): add mode change available message Oct 20, 2022
@isamu-takagi isamu-takagi marked this pull request as ready for review October 20, 2022 06:50
Copy link
Contributor

@kenji-miyake kenji-miyake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be better to use ModeChangeAvailability and the field data, but since there is no guideline for them now, I'll leave it to you for the namings.

@isamu-takagi
Copy link
Contributor Author

I would like to consider the name along with the guidelines.

@isamu-takagi isamu-takagi merged commit b4ab436 into tier4/universe Oct 24, 2022
@isamu-takagi isamu-takagi deleted the feature/launch-state branch October 24, 2022 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants