Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove .php_cs.cache, which is not part of CodeSniffer #33

Merged
merged 1 commit into from
Aug 10, 2021
Merged

Remove .php_cs.cache, which is not part of CodeSniffer #33

merged 1 commit into from
Aug 10, 2021

Conversation

rissajackson
Copy link
Contributor

No description provided.

@rissajackson rissajackson self-assigned this Aug 10, 2021
@rissajackson
Copy link
Contributor Author

rissajackson commented Aug 10, 2021 •
edited
Loading

Duster uses CodeSniffer. However, it also adds php_cs.cache to the .gitignore. It seems like that is part of CS Fixer, and I haven't found any obvious alternative cache file. I think there isn't one for CodeSniffer. However, if I missed something please feel free to let me know 😄

Screen Shot 2021-08-10 at 4 22 28 PM
Screen Shot 2021-08-10 at 4 24 27 PM

squizlabs/PHP_CodeSniffer#530

marcusmoore
marcusmoore approved these changes Aug 10, 2021
View reviewed changes
Copy link

@marcusmoore marcusmoore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 😄

@rissajackson rissajackson merged commit bfeb7ab into main Aug 10, 2021
@rissajackson rissajackson deleted the rej/remove-cs-fixer-cache branch August 10, 2021 21:34
@mattstauffer mattstauffer changed the title Remove php_cs.cache which is not part of CodeSniffer Remove .php_cs.cache, which is not part of CodeSniffer Aug 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcusmoore marcusmoore marcusmoore approved these changes

Assignees

@rissajackson rissajackson

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rissajackson @marcusmoore