Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add phpcodesniffer-composer-installer info to readme #38

Merged
merged 2 commits into from
Mar 7, 2022

Conversation

driftingly
Copy link
Member

This PR adds information on enabling the phpcodesniffer-composer-installer when installing Duster.
Aims to close #36.

README.md Outdated
>dealerdirect/phpcodesniffer-composer-installer contains a Composer plugin which is currently not in your allow-plugins config. See https://getcomposer.org/allow-plugins
>Do you trust "dealerdirect/phpcodesniffer-composer-installer" to execute code and wish to enable it now? (writes "allow-plugins" to composer.json) [y,n,d,?]

You will need to accept the [phpcodesniffer-composer-installer](https://github.com/PHPCSStandards/composer-installer) to have the PHPCS rulesets and GitHub actions to work.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this grammar isn't quite what you intended. Do you mean "to have the PHPCS rulesets and so the GitHub Actions will work"?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, thanks! I've updated the readme.

@mattstauffer
Copy link
Member

@driftingly Looks good to merge!

@driftingly driftingly merged commit 1997281 into main Mar 7, 2022
@driftingly driftingly deleted the adc/update-readme branch March 7, 2022 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GitHub Action can't find Tighten sniff
2 participants