Fix params sometimes being double-decoded #778
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calling
decodeURIbefore we try to match params allows us to handle Cyrillic characters, but it decodes other characters too, which meansdecodeURIComponenta few lines later tries to decode them again. I think this actually doesn't matter for most characters, but%specifically causes problems because it can't be decoded again on its own.I'm not positive that this solution works perfectly, if it causes other issues I might tweak how we support Cyrillic characters. Cyrillic characters are only decoded for display, in
location.hrefand other JavaScript stuff they're kept encoded so we might need to do that too.Fixes #777.