Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: build also on Windows #224

Merged
merged 1 commit into from
Jan 27, 2022
Merged

CI: build also on Windows #224

merged 1 commit into from
Jan 27, 2022

Conversation

mhujer
Copy link
Contributor

@mhujer mhujer commented Jan 27, 2022

Let's build also on Windows to prevent issues similar to #204 in the future.

@stof
Copy link
Collaborator

stof commented Jan 27, 2022

Looks like your git config --global core.autocrlf false trick does not work properly here. It still have a test failure where the expected output uses \r\n, which is not the case in the source code. I think you also need git config --global core.eol lf

@mhujer
Copy link
Contributor Author

mhujer commented Jan 27, 2022

@stof Yes, that fixes it 👍 (I've amended the commit and verified the build in my fork)

@stof stof merged commit 4ab4fe4 into tijsverkoyen:master Jan 27, 2022
@mhujer mhujer deleted the ci-windows branch February 15, 2022 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants