test unset temp flag for ART

tikv · Sep 24, 2024 · 5593212 · 5593212
1 parent 577da23
commit 5593212
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 8 deletions.
diff --git a/internal/unionstore/memdb_bench_test.go b/internal/unionstore/memdb_bench_test.go
@@ -177,10 +177,7 @@ func BenchmarkMemDbIter(b *testing.B) {
 	}
 
 	b.Run("RBT", func(b *testing.B) { fn(b, newRbtDBWithContext()) })
-	b.Run("ART", func(b *testing.B) {
-		b.Skip("unimplemented")
-		fn(b, newArtDBWithContext())
-	})
+	b.Run("ART", func(b *testing.B) { fn(b, newArtDBWithContext()) })
 }
 
 func BenchmarkMemDbCreation(b *testing.B) {

diff --git a/internal/unionstore/memdb_test.go b/internal/unionstore/memdb_test.go
@@ -978,13 +978,17 @@ func testBufferLimit(t *testing.T, buffer MemBuffer) {
 }
 
 func TestUnsetTemporaryFlag(t *testing.T) {
+	testUnsetTemporaryFlag(t, newRbtDBWithContext())
+	testUnsetTemporaryFlag(t, newArtDBWithContext())
+}
+
+func testUnsetTemporaryFlag(t *testing.T, buffer MemBuffer) {
 	require := require.New(t)
-	db := NewMemDB()
 	key := []byte{1}
 	value := []byte{2}
-	db.SetWithFlags(key, value, kv.SetNeedConstraintCheckInPrewrite)
-	db.Set(key, value)
-	flags, err := db.GetFlags(key)
+	buffer.SetWithFlags(key, value, kv.SetNeedConstraintCheckInPrewrite)
+	buffer.Set(key, value)
+	flags, err := buffer.GetFlags(key)
 	require.Nil(err)
 	require.False(flags.HasNeedConstraintCheckInPrewrite())
 }