add region cache state test & fix some issues of replica selector (#910)

Signed-off-by: you06 <[email protected]> remove duplicate code Signed-off-by: you06 <[email protected]>
tikv · Aug 14, 2023 · e2455c1 · e2455c1
1 parent a0ac170
commit e2455c1
Show file tree

Hide file tree

Showing 5 changed files with 871 additions and 3 deletions.
diff --git a/internal/locate/region_cache.go b/internal/locate/region_cache.go
@@ -534,10 +534,12 @@ func (c *RegionCache) Close() {
 	c.cancelFunc()
 }
 
+var reloadRegionInterval = int64(10 * time.Second)
+
 // asyncCheckAndResolveLoop with
 func (c *RegionCache) asyncCheckAndResolveLoop(interval time.Duration) {
 	ticker := time.NewTicker(interval)
-	reloadRegionTicker := time.NewTicker(10 * time.Second)
+	reloadRegionTicker := time.NewTicker(time.Duration(atomic.LoadInt64(&reloadRegionInterval)))
 	defer func() {
 		ticker.Stop()
 		reloadRegionTicker.Stop()

diff --git a/internal/locate/region_request.go b/internal/locate/region_request.go
@@ -2014,6 +2014,7 @@ func (s *RegionRequestSender) onRegionError(
 	}
 
 	// This peer is removed from the region. Invalidate the region since it's too stale.
+	// if the region error is from follower, can we mark the peer unavailable and reload region asynchronously?
 	if regionErr.GetRegionNotFound() != nil {
 		s.regionCache.InvalidateCachedRegion(ctx.Region)
 		return false, nil