Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kvclient panic when kill pd leader during br backup #1357

Open
Lily2025 opened this issue May 31, 2024 · 2 comments · Fixed by #1359
Open

kvclient panic when kill pd leader during br backup #1357

Lily2025 opened this issue May 31, 2024 · 2 comments · Fixed by #1359
Labels
affects-7.5

Comments

@Lily2025
Copy link

Lily2025 commented May 31, 2024 •
edited
Loading

1、run br backup
2、kill pd leader
3、br backup failed
`panic: close of closed channel

goroutine 2822 [running]:
github.com/tikv/client-go/v2/internal/client.(*batchConn).Close(...)
/root/go/pkg/mod/github.com/tikv/client-go/[email protected]/internal/client/client_batch.go:769
github.com/tikv/client-go/v2/internal/client.(*connArray).Close(0xc0004bb560)
/root/go/pkg/mod/github.com/tikv/client-go/[email protected]/internal/client/client.go:330 +0xf6
github.com/tikv/client-go/v2/internal/client.(*RPCClient).CloseAddr(0xc0007e3680, {0xc000f7e7d0, 0x44})
/root/go/pkg/mod/github.com/tikv/client-go/[email protected]/internal/client/client.go:797 +0x1e5
github.com/tikv/client-go/v2/internal/client.(*RPCClient).recycleIdleConnArray(0xc0007e3680)
/root/go/pkg/mod/github.com/tikv/client-go/[email protected]/internal/client/client_batch.go:835 +0x1f7
created by github.com/tikv/client-go/v2/internal/client.(*RPCClient).sendRequest in goroutine 2821
/root/go/pkg/mod/github.com/tikv/client-go/[email protected]/internal/client/client.go:587 +0x34b`

tidb version:
./tidb-server -V
Release Version: v7.5.2
Edition: Community
Git Commit Hash: 39ea2b30d32ab8cf486f30ca318cf2e4bd99eaef
Git Branch: HEAD
UTC Build Time: 2024-05-29 15:07:12
GoVersion: go1.21.10
Race Enabled: false
Check Table Before Drop: false
Store: unistore
2024-05-30T14:14:32.686+0800
@Lily2025 Lily2025 changed the title client panic when kill pd leader during br backup kvclient panic when kill pd leader during br backup May 31, 2024
@crazycs520 crazycs520 mentioned this issue Jun 7, 2024
Merged
@crazycs520
Copy link
Contributor

fixed by #1359

@crazycs520
Copy link
Contributor

/affect-8.1
/affect-8.0
/affect-7.5
/affect-6.5

@crazycs520 crazycs520 mentioned this issue Jul 23, 2024
Open
crazycs520 added a commit to crazycs520/client-go that referenced this issue Jul 24, 2024
@crazycs520
fix rpc client panic cause by concurrent close (tikv#1359)
1baa1dc 
close issue tikv#1357

---------

Signed-off-by: crazycs520 <[email protected]>
@crazycs520 crazycs520 mentioned this issue Jul 24, 2024
Merged
crazycs520 added a commit to crazycs520/client-go that referenced this issue Jul 24, 2024
@crazycs520
fix rpc client panic cause by concurrent close (tikv#1359)
d0ddd39 
close issue tikv#1357

Signed-off-by: crazycs520 <[email protected]>

---------

Signed-off-by: crazycs520 <[email protected]>
@crazycs520 crazycs520 mentioned this issue Jul 24, 2024
Merged
crazycs520 added a commit to crazycs520/client-go that referenced this issue Jul 24, 2024
@crazycs520
fix rpc client panic cause by concurrent close (tikv#1359)
53f4bfe 
close issue tikv#1357

Signed-off-by: crazycs520 <[email protected]>

---------

Signed-off-by: crazycs520 <[email protected]>
@crazycs520 crazycs520 mentioned this issue Jul 24, 2024
Merged
MyonKeminta pushed a commit that referenced this issue Jul 31, 2024
@crazycs520
fix rpc client panic cause by concurrent close (#1359) (#1395)
05c2c66 
close issue #1357

---------

Signed-off-by: crazycs520 <[email protected]>
@crazycs520 crazycs520 mentioned this issue Jul 31, 2024
Merged
cfzjywxk pushed a commit that referenced this issue Aug 21, 2024
@crazycs520
fix rpc client panic cause by concurrent close (#1359) (#1396)
9c2e786 
close issue #1357



---------

Signed-off-by: crazycs520 <[email protected]>
cfzjywxk pushed a commit that referenced this issue Aug 21, 2024
@crazycs520
fix rpc client panic cause by concurrent close (#1359) (#1397)
d28ae4a 
close issue #1357



---------

Signed-off-by: crazycs520 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
affects-7.5
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix rpc client panic cause by concurrent close crazycs520/client-go
3 participants
@crazycs520 @ti-chi-bot @Lily2025