increase large transaction preSplitSizeThreashold #1059
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cloud-storage-engine has larger region size, we don't want to split regions into 32MB size on large transaction write. Signed-off-by: Evan Zhou <[email protected]>
zeminzhou
approved these changes
Nov 15, 2023
iosmanthus
reviewed
Nov 15, 2023
| @@ -786,8 +786,8 @@ func txnLockTTL(startTime time.Time, txnSize int) uint64 { | |||
| return lockTTL + uint64(elapsed) | |||
| } | |||
|
|
|||
| var preSplitDetectThreshold uint32 = 100000 | |||
| var preSplitSizeThreshold uint32 = 32 << 20 | |||
| var preSplitDetectThreshold uint32 = 1000000 | |||
There was a problem hiding this comment.
How about making these optional and changing the default value in the tidb-cse?
There was a problem hiding this comment.
That would be much more work to do.
iosmanthus
approved these changes
Nov 15, 2023
coocood
added a commit
that referenced
this pull request
Nov 15, 2023
cloud-storage-engine has larger region size, we don't want to split regions into 32MB size on large transaction write. Signed-off-by: Evan Zhou <[email protected]>
iosmanthus
pushed a commit
to iosmanthus/client-go
that referenced
this pull request
Dec 21, 2023
cloud-storage-engine has larger region size, we don't want to split regions into 32MB size on large transaction write. Signed-off-by: Evan Zhou <[email protected]>
zeminzhou
pushed a commit
to zeminzhou/client-go
that referenced
this pull request
Feb 28, 2024
cloud-storage-engine has larger region size, we don't want to split regions into 32MB size on large transaction write. Signed-off-by: Evan Zhou <[email protected]>
zeminzhou
pushed a commit
to zeminzhou/client-go
that referenced
this pull request
Feb 28, 2024
cloud-storage-engine has larger region size, we don't want to split regions into 32MB size on large transaction write. Signed-off-by: Evan Zhou <[email protected]>
zeminzhou
pushed a commit
to zeminzhou/client-go
that referenced
this pull request
Feb 28, 2024
cloud-storage-engine has larger region size, we don't want to split regions into 32MB size on large transaction write. Signed-off-by: Evan Zhou <[email protected]>
zeminzhou
pushed a commit
to zeminzhou/client-go
that referenced
this pull request
Feb 28, 2024
cloud-storage-engine has larger region size, we don't want to split regions into 32MB size on large transaction write. Signed-off-by: Evan Zhou <[email protected]> Signed-off-by: zzm <[email protected]>
zeminzhou
pushed a commit
to zeminzhou/client-go
that referenced
this pull request
Mar 13, 2024
cloud-storage-engine has larger region size, we don't want to split regions into 32MB size on large transaction write. Signed-off-by: Evan Zhou <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cloud-storage-engine has larger region size 512MB, we don't want to split regions into 32MB size on large transaction write.